From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Alexander Pohoyda Newsgroups: gmane.emacs.devel Subject: Re: RMAIL, rmail-mbox-branch Date: 22 Oct 2003 22:26:09 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <87ad7tow7y.fsf_-_@oak.pohoyda.family> References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1066854845 22160 80.91.224.253 (22 Oct 2003 20:34:05 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 22 Oct 2003 20:34:05 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Oct 22 22:34:02 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1ACPgA-000619-00 for ; Wed, 22 Oct 2003 22:34:02 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1ACPgA-00008S-00 for ; Wed, 22 Oct 2003 22:34:02 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1ACPZR-00007o-GZ for emacs-devel@quimby.gnus.org; Wed, 22 Oct 2003 16:27:05 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1ACPZ8-00007c-M4 for emacs-devel@gnu.org; Wed, 22 Oct 2003 16:26:46 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1ACPYc-0008RQ-JP for emacs-devel@gnu.org; Wed, 22 Oct 2003 16:26:45 -0400 Original-Received: from [213.165.64.20] (helo=mail.gmx.net) by monty-python.gnu.org with smtp (Exim 4.24) id 1ACPYc-0008Pb-2E for emacs-devel@gnu.org; Wed, 22 Oct 2003 16:26:14 -0400 Original-Received: (qmail 21178 invoked by uid 65534); 22 Oct 2003 20:26:12 -0000 Original-Received: from p508BDF87.dip.t-dialin.net (EHLO oak.pohoyda.family) (80.139.223.135) by mail.gmx.net (mp001) with SMTP; 22 Oct 2003 22:26:12 +0200 X-Authenticated: #14602519 Original-Received: from oak.pohoyda.family (oak.pohoyda.family [127.0.0.1]) by oak.pohoyda.family (8.12.9/8.12.9) with ESMTP id h9MKQAgC002541; Wed, 22 Oct 2003 22:26:10 +0200 (CEST) (envelope-from alexander.pohoyda@gmx.net) Original-Received: (from apog@localhost) by oak.pohoyda.family (8.12.9/8.12.9/Submit) id h9MKQAJo002538; Wed, 22 Oct 2003 22:26:10 +0200 (CEST) (envelope-from alexander.pohoyda@gmx.net) X-Authentication-Warning: oak.pohoyda.family: apog set sender to alexander.pohoyda@gmx.net using -f Original-To: rms@gnu.org In-Reply-To: Original-Lines: 58 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:17356 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:17356 Problems I have encountered so far: 1) If RMAIL file does not exist, rmail-display-labels function fails deep inside rmaildesc.el and I dont see a reason to display labels if there are no messages. Proposed solution: Index: rmail.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/mail/rmail.el,v retrieving revision 1.368.2.5 diff -u -r1.368.2.5 rmail.el --- rmail.el 23 Feb 2003 00:33:25 -0000 1.368.2.5 +++ rmail.el 22 Oct 2003 19:42:05 -0000 @@ -2458,7 +2460,6 @@ ;; out of the Rmail file so as not to break other mail agents. (progn (message "No messages to show. Add something better soon.") - (rmail-display-labels) (force-mode-line-update)) ;; There are messages. Show one. 2) rmail-use-spam-filter is void variable, used in rmail-get-new-mail function. It is defined in rmail-spam-filter.el, but we cannot (require 'rmail-spam-filter) before the rmail-mode-map variable is defined further in rmail.el file. I'm not sure what is a right way to fix this. 3) Deleting the last message makes rmail-summary-goto-msg to call itself recursively in a dead loop. Proposed solution: Index: rmailsum.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/mail/rmailsum.el,v retrieving revision 1.127.2.2 diff -u -r1.127.2.2 rmailsum.el --- rmailsum.el 18 Feb 2003 16:47:23 -0000 1.127.2.2 +++ rmailsum.el 22 Oct 2003 20:22:17 -0000 @@ -1081,7 +1081,8 @@ (if (< n 1) (progn (message "No preceding message") (setq n 1))) - (if (> n total) + (if (and (> n total) + (> total 0)) (progn (message "No following message") (goto-char (point-max)) (rmail-summary-goto-msg nil nowarn skip-rmail))) -- Alexander Pohoyda PGP Key fingerprint: 7F C9 CC 5A 75 CD 89 72 15 54 5F 62 20 23 C6 44