patch: fix wrong-type-argument error in vc-registered

patch: fix wrong-type-argument error in vc-registered

[Yoichi NAKAYAMA]

The change
2004-09-12  Stefan Monnier  <monnier@iro.umontreal.ca>

        * vc-hooks.el (vc-ignore-dir-regexp): New var.

overlooked that (file-name-directory file) may return nil.
Following is the patch against it.

Regards,
-- 
Yoichi NAKAYAMA
\f
Index: vc-hooks.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/vc-hooks.el,v
retrieving revision 1.169
diff -u -r1.169 vc-hooks.el
--- vc-hooks.el	13 Sep 2004 03:36:11 -0000	1.169
+++ vc-hooks.el	12 Oct 2004 14:38:39 -0000
@@ -336,7 +336,9 @@
 backend is tried first."
   (let (handler)
     (cond
-     ((string-match vc-ignore-dir-regexp (file-name-directory file)) nil)
+     ((and (file-name-directory file)
+	   (string-match vc-ignore-dir-regexp (file-name-directory file)))
+      nil)
      ((and (boundp 'file-name-handler-alist)
           (setq handler (find-file-name-handler file 'vc-registered)))
       ;; handler should set vc-backend and return t if registered

Re: patch: fix wrong-type-argument error in vc-registered

[Stefan Monnier]

> 2004-09-12  Stefan Monnier  <monnier@iro.umontreal.ca>

>         * vc-hooks.el (vc-ignore-dir-regexp): New var.

> overlooked that (file-name-directory file) may return nil.
> Following is the patch against it.

Hmm... your patch looks fine, except that I don't understand why it's
needed: I thought vc-registered is only ever called with an absolute file
name, and (file-name-directory file) never returns nil if file is an
absolute file name.

In which cases does it return nil on an absolute file name, or in which
cases is vc-registered called with a non-absolute file name?


        Stefan

Re: patch: fix wrong-type-argument error in vc-registered

[Romain Francoise]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> In which cases does it return nil on an absolute file name, or in which
> cases is vc-registered called with a non-absolute file name?

Let me guess.. when buffer-file-name is "", like in ERC buffers?

I sent the exact same patch on Sep 18th.

-- 
Romain Francoise <romain@orebokech.com> | It was fourteen degrees below
it's a miracle -- http://orebokech.com/ | on a screeching march 23.

Re: patch: fix wrong-type-argument error in vc-registered

[Stefan]

>> In which cases does it return nil on an absolute file name, or in which
>> cases is vc-registered called with a non-absolute file name?

> Let me guess.. when buffer-file-name is "", like in ERC buffers?

> I sent the exact same patch on Sep 18th.

But as mentioned at that time, "" is not a valid buffer-file-name.


        Stefan

Re: patch: fix wrong-type-argument error in vc-registered

[Yoichi NAKAYAMA]

At Tue, 12 Oct 2004 12:14:39 -0400,
Stefan Monnier wrote:
> 
> > 2004-09-12  Stefan Monnier  <monnier@iro.umontreal.ca>
> 
> >         * vc-hooks.el (vc-ignore-dir-regexp): New var.
> 
> > overlooked that (file-name-directory file) may return nil.
> > Following is the patch against it.
> 
> Hmm... your patch looks fine, except that I don't understand why it's
> needed: I thought vc-registered is only ever called with an absolute file
> name, and (file-name-directory file) never returns nil if file is an
> absolute file name.
> 
> In which cases does it return nil on an absolute file name, or in which
> cases is vc-registered called with a non-absolute file name?

For example, mime-view.el in EMIKO module
http://cvs.m17n.org/cgi-bin/viewcvs/semi/mime-view.el?rev=1.150.2.33.2.38&only_with_tag=emiko-1_14&content-type=text/vnd.viewcvs-markup
calles set-auto-mode after setting buffer-file-name to non-absolute path
for highlighting.
-- 
Yoichi NAKAYAMA

Re: patch: fix wrong-type-argument error in vc-registered

[Stefan]

> For example, mime-view.el in EMIKO module
> http://cvs.m17n.org/cgi-bin/viewcvs/semi/mime-view.el?rev=1.150.2.33.2.38&only_with_tag=emiko-1_14&content-type=text/vnd.viewcvs-markup
> calles set-auto-mode after setting buffer-file-name to non-absolute path
> for highlighting.

mime-view.el should be fixed then: buffer-file-name needs to have an
absolute path.  Several other packages rely on this.  Admittedly, it seems
that vc-registered is the only function that's always used that relies on
this, so fixing it will provide the illusion that things work, but in
reality, they'll break with things like uniquify as well (to name one other
case I happen to know of).


        Stefan

Re: patch: fix wrong-type-argument error in vc-registered

[Yoichi NAKAYAMA]

At Tue, 12 Oct 2004 21:19:42 -0400,
Stefan wrote:
> 
> > For example, mime-view.el in EMIKO module
> > http://cvs.m17n.org/cgi-bin/viewcvs/semi/mime-view.el?rev=1.150.2.33.2.38&only_with_tag=emiko-1_14&content-type=text/vnd.viewcvs-markup
> > calles set-auto-mode after setting buffer-file-name to non-absolute path
> > for highlighting.
> 
> mime-view.el should be fixed then: buffer-file-name needs to have an
> absolute path.  Several other packages rely on this.  Admittedly, it seems
> that vc-registered is the only function that's always used that relies on
> this, so fixing it will provide the illusion that things work, but in
> reality, they'll break with things like uniquify as well (to name one other
> case I happen to know of).

OK, I'll write to developers of mime-view.el.
By the way, the restriction should be documented on buffer-file-name<v>?
I found description for buffer-file-name<v> but not for the variable.

Regards,
-- 
Yoichi NAKAYAMA

Re: patch: fix wrong-type-argument error in vc-registered

[Yoichi NAKAYAMA]

At Wed, 13 Oct 2004 10:37:16 +0900,
Yoichi NAKAYAMA wrote:
> By the way, the restriction should be documented on buffer-file-name<v>?
> I found description for buffer-file-name<v> but not for the variable.

Oops, it was to be:
I found description for buffer-file-name<f> but not for the variable.

Regards,
-- 
Yoichi NAKAYAMA