From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Mode line faces on ttys Date: Wed, 17 Aug 2005 19:43:22 +0300 Organization: JURTA Message-ID: <87acjgbjr9.fsf@jurta.org> References: <878xz0u3ib.fsf@pacem.orebokech.com> <87u0hoipt5.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1124297824 29287 80.91.229.2 (17 Aug 2005 16:57:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 17 Aug 2005 16:57:04 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 17 18:57:01 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1E5RC7-0002EI-Je for ged-emacs-devel@m.gmane.org; Wed, 17 Aug 2005 18:55:15 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E5RFa-0007rA-FG for ged-emacs-devel@m.gmane.org; Wed, 17 Aug 2005 12:58:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E5RDy-0007NE-8P for emacs-devel@gnu.org; Wed, 17 Aug 2005 12:57:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E5RDq-0007Lz-Ul for emacs-devel@gnu.org; Wed, 17 Aug 2005 12:57:05 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E5RDp-00079M-Uy for emacs-devel@gnu.org; Wed, 17 Aug 2005 12:57:02 -0400 Original-Received: from [194.126.101.111] (helo=mail.neti.ee) by monty-python.gnu.org with esmtp (Exim 4.34) id 1E5RIs-0001ml-UU for emacs-devel@gnu.org; Wed, 17 Aug 2005 13:02:15 -0400 Original-Received: from mail.neti.ee (80-235-37-17-dsl.mus.estpak.ee [80.235.37.17]) by Relayhost1.neti.ee (Postfix) with ESMTP id 190471F7F for ; Wed, 17 Aug 2005 19:46:05 +0300 (EEST) Original-To: emacs-devel@gnu.org In-Reply-To: <87u0hoipt5.fsf@jurta.org> (Juri Linkov's message of "Wed, 17 Aug 2005 17:46:46 +0300") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-2.2.1 (20041222) (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:42189 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:42189 While looking at inverse-related functions , I noticed that there are two duplicate functions in faces.el: `set-face-underline' and `set-face-underline-p'. Since `set-face-underline-p' is documented in the manual, so I assume that the correct name is `set-face-underline-p'. The patch below deletes the function `set-face-underline' (with moving its docstring to the `set-face-underline-p', because the docstring of `set-face-underline' is more complete), and replaces `set-face-underline' with an alias to `set-face-underline-p'. Index: lisp/faces.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/faces.el,v retrieving revision 1.333 diff -c -r1.333 faces.el *** lisp/faces.el 6 Aug 2005 22:13:42 -0000 1.333 --- lisp/faces.el 17 Aug 2005 16:29:34 -0000 *************** *** 770,776 **** (set-face-attribute face frame :stipple (or stipple 'unspecified))) ! (defun set-face-underline (face underline &optional frame) "Specify whether face FACE is underlined. UNDERLINE nil means FACE explicitly doesn't underline. UNDERLINE non-nil means FACE explicitly does underlining --- 770,776 ---- (set-face-attribute face frame :stipple (or stipple 'unspecified))) ! (defun set-face-underline-p (face underline-p &optional frame) "Specify whether face FACE is underlined. UNDERLINE nil means FACE explicitly doesn't underline. UNDERLINE non-nil means FACE explicitly does underlining *************** *** 781,800 **** (interactive (let ((list (read-face-and-attribute :underline))) (list (car list) (eq (car (cdr list)) t)))) - (set-face-attribute face frame :underline underline)) - - - (defun set-face-underline-p (face underline-p &optional frame) - "Specify whether face FACE is underlined. - UNDERLINE-P nil means FACE explicitly doesn't underline. - UNDERLINE-P non-nil means FACE explicitly does underlining. - FRAME nil or not specified means change face on all frames. - Use `set-face-attribute' to ``unspecify'' underlining." - (interactive - (let ((list (read-face-and-attribute :underline))) - (list (car list) (eq (car (cdr list)) t)))) (set-face-attribute face frame :underline underline-p)) (defun set-face-inverse-video-p (face inverse-video-p &optional frame) "Specify whether face FACE is in inverse video. --- 781,791 ---- (interactive (let ((list (read-face-and-attribute :underline))) (list (car list) (eq (car (cdr list)) t)))) (set-face-attribute face frame :underline underline-p)) + (define-obsolete-function-alias 'set-face-underline + 'set-face-underline-p "22.1") + (defun set-face-inverse-video-p (face inverse-video-p &optional frame) "Specify whether face FACE is in inverse video. -- Juri Linkov http://www.jurta.org/emacs/