From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Index header in diff-mode Date: Sat, 10 Dec 2005 01:55:34 +0200 Organization: JURTA Message-ID: <87acf9c204.fsf@jurta.org> References: <873bl4f9wd.fsf@jurta.org> <87lkyupz5j.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1134173428 6992 80.91.229.2 (10 Dec 2005 00:10:28 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 10 Dec 2005 00:10:28 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 10 01:10:19 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EksJO-0002Kf-Gp for ged-emacs-devel@m.gmane.org; Sat, 10 Dec 2005 01:10:02 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EksJj-0006b7-Sm for ged-emacs-devel@m.gmane.org; Fri, 09 Dec 2005 19:10:24 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EksBR-0004oq-JO for emacs-devel@gnu.org; Fri, 09 Dec 2005 19:01:50 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EksBP-0004oG-Fm for emacs-devel@gnu.org; Fri, 09 Dec 2005 19:01:47 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EksBN-0004nm-8o for emacs-devel@gnu.org; Fri, 09 Dec 2005 19:01:45 -0500 Original-Received: from [194.126.101.111] (helo=mail.neti.ee) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EksCe-0004mX-Dq for emacs-devel@gnu.org; Fri, 09 Dec 2005 19:03:04 -0500 Original-Received: from mail.neti.ee (80-235-33-195-dsl.mus.estpak.ee [80.235.33.195]) by Relayhost1.neti.ee (Postfix) with ESMTP id 04126174E; Sat, 10 Dec 2005 02:01:37 +0200 (EET) Original-To: Stefan Monnier In-Reply-To: (Stefan Monnier's message of "Fri, 09 Dec 2005 09:38:40 -0500") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-2.2.1 (20041222) (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:47358 Archived-At: >>>> After saving them to files and visiting in diff-mode, sometimes I type >>>> `C-c C-c' or `RET' on such index headers with the intention to visit the >>>> first hunk. But instead, it visits the last hunk of the previous file >>>> in the same multi-file diff. Wouldn't it be better to handle the index >>>> header as part of the file header? >>> >>> I think you're right. Feel free to make this change, > >> I tried to add an optional Index regexp to diff-file-header-re: > > I think it's the wrong way to go. You should try and fix > diff-goto-source more specifically. Yes, diff-goto-source should be fixed too, because currently it doesn't work even on normal diff file headers. But I thought also that diff-file-next and diff-file-prev should stop at the index header because some other commands like diff-file-kill already take into account the index header. -- Juri Linkov http://www.jurta.org/emacs/