From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Match color fix Date: Sun, 11 Mar 2007 21:41:01 +0200 Organization: JURTA Message-ID: <87abyj7e56.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1173643222 7647 80.91.229.12 (11 Mar 2007 20:00:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 11 Mar 2007 20:00:22 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 11 21:00:15 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HQUDH-0002Ph-0K for ged-emacs-devel@m.gmane.org; Sun, 11 Mar 2007 21:00:15 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HQUDq-0004rw-HE for ged-emacs-devel@m.gmane.org; Sun, 11 Mar 2007 15:00:50 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HQUDd-0004rh-Hx for emacs-devel@gnu.org; Sun, 11 Mar 2007 16:00:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HQUDb-0004rU-60 for emacs-devel@gnu.org; Sun, 11 Mar 2007 16:00:36 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HQUDb-0004rR-1C for emacs-devel@gnu.org; Sun, 11 Mar 2007 15:00:35 -0500 Original-Received: from relay02.kiev.sovam.com ([62.64.120.197]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HQUD0-0008Hg-Fe for emacs-devel@gnu.org; Sun, 11 Mar 2007 15:59:58 -0400 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay02.kiev.sovam.com with esmtp (Exim 4.60) (envelope-from ) id 1HQUCp-000CCs-RR for emacs-devel@gnu.org; Sun, 11 Mar 2007 21:59:56 +0200 User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.93 (gnu/linux) X-Scanner-Signature: 362d5034abbfed611c52a2913ea5ff69 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 854 [Mar 11 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Method: none X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release X-detected-kernel: FreeBSD 4.8-5.1 (or MacOS X 10.2-10.3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67728 Archived-At: The most widespread background color to highlight matches nowadays is yellow. It is used by many popular programs like Firefox to highlight search results on the Web page, Web services like Google to highlight search terms on the result page, and by many other programs and web sites. It is a good color because it is very noticeable, and at the same time the text on yellow background is still well readable. It would be good to use this background color for the `match' face on the default white background in Emacs. The `match' face is a new face in Emacs 22. The reason why I proposed its current default color is because it looks well only on my then background which was darker than the default white background (it was actually "AntiqueWhite3"). And now after looking at this face on the default white background I feel guilty for proposing such a bad color. Fortunately, it is not too late to fix this misfeature before the release with the following patch: Index: lisp/replace.el =================================================================== RCS file: /sources/emacs/emacs/lisp/replace.el,v retrieving revision 1.253 diff -c -r1.253 replace.el *** lisp/replace.el 8 Mar 2007 15:17:42 -0000 1.253 --- lisp/replace.el 11 Mar 2007 19:33:11 -0000 *************** *** 849,858 **** (defface match '((((class color) (min-colors 88) (background light)) ! :background "Tan") (((class color) (min-colors 88) (background dark)) :background "RoyalBlue3") ! (((class color) (min-colors 8)) :background "blue" :foreground "white") (((type tty) (class mono)) :inverse-video t) --- 849,860 ---- (defface match '((((class color) (min-colors 88) (background light)) ! :background "yellow") (((class color) (min-colors 88) (background dark)) :background "RoyalBlue3") ! (((class color) (min-colors 8) (background light)) ! :background "yellow" :foreground "black") ! (((class color) (min-colors 8) (background dark)) :background "blue" :foreground "white") (((type tty) (class mono)) :inverse-video t) -- Juri Linkov http://www.jurta.org/emacs/