From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: EOL conversion of files in .tar archives Date: Tue, 22 May 2007 23:18:04 -0400 Message-ID: <87abvwrzwz.fsf@stupidchicken.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1179890306 10403 80.91.229.12 (23 May 2007 03:18:26 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 23 May 2007 03:18:26 +0000 (UTC) Cc: emacs-devel@gnu.org, handa@m17n.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 23 05:18:22 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HqhMi-0006Rj-Lp for ged-emacs-devel@m.gmane.org; Wed, 23 May 2007 05:18:20 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HqhMj-0002YL-Ub for ged-emacs-devel@m.gmane.org; Tue, 22 May 2007 23:18:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HqhMf-0002Ug-Si for emacs-devel@gnu.org; Tue, 22 May 2007 23:18:17 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HqhMf-0002UJ-K6 for emacs-devel@gnu.org; Tue, 22 May 2007 23:18:17 -0400 Original-Received: from south-station-annex.mit.edu ([18.72.1.2]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HqhMf-0001oS-Bx; Tue, 22 May 2007 23:18:17 -0400 Original-Received: from central-city-carrier-station.mit.edu (CENTRAL-CITY-CARRIER-STATION.MIT.EDU [18.7.7.72]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id l4N3IF34025809; Tue, 22 May 2007 23:18:15 -0400 (EDT) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by central-city-carrier-station.mit.edu (8.13.6/8.9.2) with ESMTP id l4N3I6uS007990; Tue, 22 May 2007 23:18:06 -0400 (EDT) Original-Received: from localhost (SYDNEYPACIFIC-SIX-TWELVE.MIT.EDU [18.95.7.101]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id l4N3I5UB029981; Tue, 22 May 2007 23:18:05 -0400 (EDT) Original-Received: from cyd by localhost with local (Exim 3.36 #1 (Debian)) id 1HqhMT-0001t0-00; Tue, 22 May 2007 23:18:05 -0400 In-Reply-To: (Eli Zaretskii's message of "Tue\, 22 May 2007 15\:21\:38 +0300") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.99 (gnu/linux) X-Scanned-By: MIMEDefang 2.42 X-Spam-Score: -2.599 X-detected-kernel: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71640 Archived-At: Eli Zaretskii writes: > > This solves the problem with the EOL decoding, but reveals a very > strange phenomenon: dos-w32.el and dos-w32.elc behave differently. > ... > - (set-buffer-file-coding-system coding)) > + (set-buffer-file-coding-system last-coding-system-used t)) What's the rationale for this change? The purpose of the old code was quite transparent; changing it to use last-coding-system-used is not obvious, and deserves at least a comment. (And I think the use of last-coding-system-used leads to the "strange phenomenon" mentioned above.) All this makes me more dubious about adding this code now. We should either make this entire change conditional on win32 (hedious as the resulting code might be) or simply postphone it for Emacs 22.2.