unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, handa@m17n.org
Subject: Re: EOL conversion of files in .tar archives
Date: Tue, 22 May 2007 23:18:04 -0400	[thread overview]
Message-ID: <87abvwrzwz.fsf@stupidchicken.com> (raw)
In-Reply-To: <uzm3xjbfx.fsf@gnu.org> (Eli Zaretskii's message of "Tue\, 22 May 2007 15\:21\:38 +0300")

Eli Zaretskii <eliz@gnu.org> writes:
>
> This solves the problem with the EOL decoding, but reveals a very
> strange phenomenon: dos-w32.el and dos-w32.elc behave differently.
> ...
> -	    (set-buffer-file-coding-system coding))
> +	    (set-buffer-file-coding-system last-coding-system-used t))

What's the rationale for this change?  The purpose of the old code was
quite transparent; changing it to use last-coding-system-used is not
obvious, and deserves at least a comment.  (And I think the use of
last-coding-system-used leads to the "strange phenomenon" mentioned
above.)

All this makes me more dubious about adding this code now.  We should
either make this entire change conditional on win32 (hedious as the
resulting code might be) or simply postphone it for Emacs 22.2.

  parent reply	other threads:[~2007-05-23  3:18 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-20 19:28 EOL conversion of files in .tar archives Eli Zaretskii
2007-05-21  4:48 ` Kenichi Handa
2007-05-21  5:15   ` David Kastrup
2007-05-21 19:54     ` Eli Zaretskii
2007-05-22  8:30     ` Richard Stallman
2007-05-23 18:43       ` Eli Zaretskii
2007-05-21 20:45   ` Eli Zaretskii
2007-05-21 22:58     ` Chong Yidong
2007-05-22  6:39       ` Eli Zaretskii
2007-05-22  6:53         ` David Kastrup
2007-05-22  7:01           ` Eli Zaretskii
2007-05-22 15:49         ` Richard Stallman
2007-05-22 16:25           ` Eli Zaretskii
2007-05-22 14:52       ` Richard Stallman
2007-05-22 21:20         ` David Kastrup
2007-05-22 14:52     ` Richard Stallman
2007-05-22 16:20       ` Eli Zaretskii
2007-05-22 11:19   ` Eli Zaretskii
2007-05-22 12:21     ` Eli Zaretskii
2007-05-22 21:10       ` Chong Yidong
2007-05-22 21:18         ` Lennart Borgman (gmail)
2007-05-22 21:19           ` Chong Yidong
2007-05-23  6:56           ` Eli Zaretskii
2007-05-23  3:18       ` Chong Yidong [this message]
2007-05-23  5:58         ` Kenichi Handa
2007-05-23  7:15         ` Eli Zaretskii
2007-05-23 12:34           ` Eli Zaretskii
2007-05-23 13:01             ` Kenichi Handa
2007-05-23 17:33               ` Eli Zaretskii
2007-05-23 18:02                 ` David Kastrup
2007-05-23 18:32                   ` Eli Zaretskii
2007-05-23 18:43                     ` David Kastrup
2007-05-24  1:01                 ` Kenichi Handa
2007-05-24  7:48                   ` Eli Zaretskii
2007-05-24  8:15                     ` Kenichi Handa
2007-05-24  8:32                       ` Eli Zaretskii
2007-05-27  5:45                         ` Kenichi Handa
2007-05-27 23:21                           ` Richard Stallman
2007-05-28  3:12                             ` Eli Zaretskii
2007-05-29  0:02                               ` Richard Stallman
2007-05-23 13:31             ` Chong Yidong
2007-05-23 17:32               ` Eli Zaretskii
2007-05-22 23:09     ` Richard Stallman
2007-05-23  7:03       ` Eli Zaretskii
2007-05-23 18:56         ` Richard Stallman
2007-05-23  0:59     ` Chong Yidong
2007-05-23 18:45       ` Chong Yidong
2007-05-23 19:31       ` Eli Zaretskii
2007-05-23  1:22     ` Kenichi Handa
2007-05-23  7:10       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87abvwrzwz.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=handa@m17n.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).