remove dabbrev--scanning-message?

remove dabbrev--scanning-message?

[Sean O'Rourke]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

When `dabbrev-expand' is invoked with many buffers and it fails
to find an expansion, there is an annoying forced pause while it
scans every buffer and emits uninteresting progress messages.  If
these messages are removed, a failed expansion is nearly
instantaneous, so I don't see any benefit to having progress
messages.  Patch attached.

/s

2007-07-22  Sean O'Rourke <sorourke@cs.ucsd.edu>

	* dabbrev.el (dabbrev--scanning-message): removed.
        (dabbrev--find-expansion): remove calls.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1408 bytes --]

Index: dabbrev.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/dabbrev.el,v
retrieving revision 1.85
diff -u -r1.85 dabbrev.el
--- dabbrev.el	16 May 2007 13:13:20 -0000	1.85
+++ dabbrev.el	23 Jul 2007 05:07:50 -0000
@@ -711,10 +711,6 @@
 	(setq all-expansions (cons expansion all-expansions))))
     all-expansions))
 
-(defun dabbrev--scanning-message ()
-  (unless (window-minibuffer-p (selected-window))
-    (message "Scanning `%s'" (buffer-name (current-buffer)))))
-
 (defun dabbrev--ignore-buffer-p (buffer)
   "Return non-nil if BUFFER should be ignored by dabbrev."
   (let ((bn (buffer-name buffer)))
@@ -740,8 +736,7 @@
     ;; If we were scanning something other than the current buffer,
     ;; continue scanning there.
     (when dabbrev--last-buffer
-      (set-buffer dabbrev--last-buffer)
-      (dabbrev--scanning-message))
+      (set-buffer dabbrev--last-buffer))
     (or
      ;; ------------------------------------------
      ;; Look backward in current buffer.
@@ -781,7 +776,6 @@
 	 (while (and (not expansion) dabbrev--friend-buffer-list)
 	   (setq dabbrev--last-buffer (pop dabbrev--friend-buffer-list))
 	   (set-buffer dabbrev--last-buffer)
-	   (dabbrev--scanning-message)
 	   (setq dabbrev--last-expansion-location (point-min))
 	   (setq expansion (dabbrev--try-find abbrev nil 1 ignore-case)))
 	 expansion)))))

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: remove dabbrev--scanning-message?

[Thien-Thi Nguyen]

() "Sean O'Rourke" <sorourke@cs.ucsd.edu>
() Sun, 22 Jul 2007 22:16:36 -0700

   so I don't see any benefit to having progress
   messages.  Patch attached.

right, so what you want to do is to submit a patch
that preserves this for those that see the benefit
while not making you wait, annoyed.

how about replacing the message calls w/ a progress reporter?

thi

Re: remove dabbrev--scanning-message?

[Sean O'Rourke]

Thien-Thi Nguyen <ttn@gnuvola.org> writes:

> () "Sean O'Rourke" <sorourke@cs.ucsd.edu>
> () Sun, 22 Jul 2007 22:16:36 -0700
>
>    so I don't see any benefit to having progress
>    messages.  Patch attached.
>
> right, so what you want to do is to submit a patch
> that preserves this for those that see the benefit
> while not making you wait, annoyed.
>
> how about replacing the message calls w/ a progress reporter?

I can do this, but progress reporting only makes sense when
there's a noticeable delay.  I'm genuinely curious: For those
people on the list with older hardware and/or many open buffers,
with the progress messages removed, does a failed dabbrev-expand
take more than an instant?  It didn't for me, with 80 or so
buffers and average hardware.

/s

Re: remove dabbrev--scanning-message?

[Eli Zaretskii]

> From: "Sean O'Rourke" <sorourke@cs.ucsd.edu>
> Date: Mon, 23 Jul 2007 06:40:47 -0700
> Cc: emacs-devel@gnu.org
> 
> I'm genuinely curious: For those
> people on the list with older hardware and/or many open buffers,
> with the progress messages removed, does a failed dabbrev-expand
> take more than an instant?  It didn't for me, with 80 or so
> buffers and average hardware.

What kind of hardware is ``average'' by your standards?  You might be
surprised to hear what people use to run Emacs.

Re: remove dabbrev--scanning-message?

[Eli Zaretskii]

> From: "Sean O'Rourke" <sorourke@cs.ucsd.edu>
> Date: Sun, 22 Jul 2007 22:16:36 -0700
> 
> When `dabbrev-expand' is invoked with many buffers and it fails
> to find an expansion, there is an annoying forced pause while it
> scans every buffer and emits uninteresting progress messages.  If
> these messages are removed, a failed expansion is nearly
> instantaneous, so I don't see any benefit to having progress
> messages.  Patch attached.

Instead of deleting the functionality altogether, I'd prefer that the
messages could be enabled by customizing some option.  The option
could be off by default (which should be noted in etc/NEWS, btw).

Re: remove dabbrev--scanning-message?

[Richard Stallman]

    Instead of deleting the functionality altogether, I'd prefer that the
    messages could be enabled by customizing some option.  The option
    could be off by default (which should be noted in etc/NEWS, btw).

I hesitate to do this, because I am not convinced that the case
in which the messages cause the bulk of the delay is the usual case.

Re: remove dabbrev--scanning-message?

[Sean O'Rourke]

Richard Stallman <rms@gnu.org> writes:

>     Instead of deleting the functionality altogether, I'd prefer that the
>     messages could be enabled by customizing some option.  The option
>     could be off by default (which should be noted in etc/NEWS, btw).
>
> I hesitate to do this, because I am not convinced that the case
> in which the messages cause the bulk of the delay is the usual case.

The patch I posted yesterday using make-progress-reporter
performs acceptably for me, and doesn't require another
customization variable.

/s

Re: remove dabbrev--scanning-message?

[Richard Stallman]

For me, it takes 7 seconds or so with the messages, and 5 seconds with
no messages.  I think I would rather have the messages.

Do you have a lot of small buffers?

Re: remove dabbrev--scanning-message?

[Sean O'Rourke]

Richard Stallman <rms@gnu.org> writes:

> For me, it takes 7 seconds or so with the messages, and 5 seconds with
> no messages.  I think I would rather have the messages.

Ouch.  For me it's 0.5 or 1 second with messages, and nearly
imperceptible without, making dabbrev-expand convenient for
completing long words while typing text.  It sounds like this
feature is almost completely useless to you now.

> Do you have a lot of small buffers?

I currently have 76 buffers taking 7864231 bytes, but about 6M of
that is an enormous *info* buffer, so the median is 3278 bytes.
I'm not sure what people think of as "small".

Given that people do see substantial delays, it seems like the
best approach would be:

    (1) Replace the messages with a progress-reporter (assuming
        it's faster), since the filenames probably go by too fast to
        read anyways.
    (2) Provide a user option `dabbrev-report-progress', true by
        default, to enable/disable this feedback.

/s

Re: remove dabbrev--scanning-message?

[Thien-Thi Nguyen]

() "Sean O'Rourke" <sorourke@cs.ucsd.edu>
() Mon, 23 Jul 2007 15:58:56 -0700

       (1) Replace the messages with a progress-reporter (assuming
           it's faster), since the filenames probably go by too fast
           to read anyways.
       (2) Provide a user option `dabbrev-report-progress', true by
           default, to enable/disable this feedback.

a progress reporter displays nothing until a certain threshold is
reached (arg MIN-TIME to make-progress-reporter).  you can avoid the
need for (2) by setting a high enough MIN-TIME, perhaps 1.5 to two
seconds.

thi

Re: remove dabbrev--scanning-message?

[Sean O'Rourke]

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

Thien-Thi Nguyen <ttn@gnuvola.org> writes:

> () "Sean O'Rourke" <sorourke@cs.ucsd.edu>
> () Mon, 23 Jul 2007 15:58:56 -0700
>
>        (1) Replace the messages with a progress-reporter (assuming
>            it's faster), since the filenames probably go by too fast
>            to read anyways.
>        (2) Provide a user option `dabbrev-report-progress', true by
>            default, to enable/disable this feedback.
>
> a progress reporter displays nothing until a certain threshold is
> reached (arg MIN-TIME to make-progress-reporter).

Thanks for the info.  Here's a patch that does this with a
1.5-sec delay.  I left out the current window-minibuffer-p check,
because it seems like the progress-reporter-* functions should
control this behavior.

2007-07-22  Sean O'Rourke <sorourke@cs.ucsd.edu>

	* dabbrev.el (dabbrev--scanning-message): removed.
        (dabbrev--find-expansion): use a progress reporter
        instead of dabbrev--scanning-message.
        (dabbrev--progress-reporter): new variable.

/s


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 2639 bytes --]

Index: dabbrev.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/dabbrev.el,v
retrieving revision 1.85
diff -u -r1.85 dabbrev.el
--- dabbrev.el	16 May 2007 13:13:20 -0000	1.85
+++ dabbrev.el	24 Jul 2007 00:40:05 -0000
@@ -332,6 +332,9 @@
 ;; The regexp for recognizing a character in an abbreviation.
 (defvar dabbrev--abbrev-char-regexp nil)
 
+;; The progress reporter for buffer-scanning progress.
+(defvar dabbrev--progress-reporter nil)
+
 ;;----------------------------------------------------------------
 ;; Macros
 ;;----------------------------------------------------------------
@@ -711,10 +714,6 @@
 	(setq all-expansions (cons expansion all-expansions))))
     all-expansions))
 
-(defun dabbrev--scanning-message ()
-  (unless (window-minibuffer-p (selected-window))
-    (message "Scanning `%s'" (buffer-name (current-buffer)))))
-
 (defun dabbrev--ignore-buffer-p (buffer)
   "Return non-nil if BUFFER should be ignored by dabbrev."
   (let ((bn (buffer-name buffer)))
@@ -740,8 +739,7 @@
     ;; If we were scanning something other than the current buffer,
     ;; continue scanning there.
     (when dabbrev--last-buffer
-      (set-buffer dabbrev--last-buffer)
-      (dabbrev--scanning-message))
+      (set-buffer dabbrev--last-buffer))
     (or
      ;; ------------------------------------------
      ;; Look backward in current buffer.
@@ -773,15 +771,20 @@
 	 ;; If we have just now begun to search other buffers,
 	 ;; determine which other buffers we should check.
 	 ;; Put that list in dabbrev--friend-buffer-list.
-	 (or dabbrev--friend-buffer-list
-	     (setq dabbrev--friend-buffer-list
-		   (dabbrev--make-friend-buffer-list))))
+	 (unless dabbrev--friend-buffer-list
+           (setq dabbrev--friend-buffer-list
+                 (dabbrev--make-friend-buffer-list))
+           (setq dabbrev--progress-reporter
+                 (make-progress-reporter
+                  "Scanning for dabbrevs..."
+                  (- (length dabbrev--friend-buffer-list)) 0 0 1 1.5))))
        ;; Walk through the buffers till we find a match.
        (let (expansion)
 	 (while (and (not expansion) dabbrev--friend-buffer-list)
 	   (setq dabbrev--last-buffer (pop dabbrev--friend-buffer-list))
 	   (set-buffer dabbrev--last-buffer)
-	   (dabbrev--scanning-message)
+           (progress-reporter-update dabbrev--progress-reporter
+                                     (- (length dabbrev--friend-buffer-list)))
 	   (setq dabbrev--last-expansion-location (point-min))
 	   (setq expansion (dabbrev--try-find abbrev nil 1 ignore-case)))
 	 expansion)))))

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: remove dabbrev--scanning-message?

[Richard Stallman]

If others generally prefer the progress reporter, I won't object.

Re: remove dabbrev--scanning-message?

[Thien-Thi Nguyen]

() "Sean O'Rourke" <sorourke@cs.ucsd.edu>
() Mon, 23 Jul 2007 17:40:29 -0700

   2007-07-22  Sean O'Rourke <sorourke@cs.ucsd.edu>

           * dabbrev.el (dabbrev--scanning-message): removed.
           (dabbrev--find-expansion): use a progress reporter
           instead of dabbrev--scanning-message.
           (dabbrev--progress-reporter): new variable.

i would like to install this.  rms, is this (see below) suitable
for immediate ("tiny change") installation or should we ask for
copyright assignment?

thi


____________________________________________________________
--- dabbrev.el	16 May 2007 13:13:20 -0000	1.85
+++ dabbrev.el	24 Jul 2007 00:40:05 -0000
@@ -332,6 +332,9 @@
 ;; The regexp for recognizing a character in an abbreviation.
 (defvar dabbrev--abbrev-char-regexp nil)

+;; The progress reporter for buffer-scanning progress.
+(defvar dabbrev--progress-reporter nil)
+
 ;;----------------------------------------------------------------
 ;; Macros
 ;;----------------------------------------------------------------
@@ -711,10 +714,6 @@
        (setq all-expansions (cons expansion all-expansions))))
     all-expansions))

-(defun dabbrev--scanning-message ()
-  (unless (window-minibuffer-p (selected-window))
-    (message "Scanning `%s'" (buffer-name (current-buffer)))))
-
 (defun dabbrev--ignore-buffer-p (buffer)
   "Return non-nil if BUFFER should be ignored by dabbrev."
   (let ((bn (buffer-name buffer)))
@@ -740,8 +739,7 @@
     ;; If we were scanning something other than the current buffer,
     ;; continue scanning there.
     (when dabbrev--last-buffer
-      (set-buffer dabbrev--last-buffer)
-      (dabbrev--scanning-message))
+      (set-buffer dabbrev--last-buffer))
     (or
      ;; ------------------------------------------
      ;; Look backward in current buffer.
@@ -773,15 +771,20 @@
         ;; If we have just now begun to search other buffers,
         ;; determine which other buffers we should check.
         ;; Put that list in dabbrev--friend-buffer-list.
-	 (or dabbrev--friend-buffer-list
-	     (setq dabbrev--friend-buffer-list
-		   (dabbrev--make-friend-buffer-list))))
+	 (unless dabbrev--friend-buffer-list
+           (setq dabbrev--friend-buffer-list
+                 (dabbrev--make-friend-buffer-list))
+           (setq dabbrev--progress-reporter
+                 (make-progress-reporter
+                  "Scanning for dabbrevs..."
+                  (- (length dabbrev--friend-buffer-list)) 0 0 1 1.5))))
        ;; Walk through the buffers till we find a match.
        (let (expansion)
         (while (and (not expansion) dabbrev--friend-buffer-list)
           (setq dabbrev--last-buffer (pop dabbrev--friend-buffer-list))
           (set-buffer dabbrev--last-buffer)
-	   (dabbrev--scanning-message)
+           (progress-reporter-update dabbrev--progress-reporter
+                                     (- (length dabbrev--friend-buffer-list)))
           (setq dabbrev--last-expansion-location (point-min))
           (setq expansion (dabbrev--try-find abbrev nil 1 ignore-case)))
         expansion)))))

Re: remove dabbrev--scanning-message?

[Sean O'Rourke]

Thien-Thi Nguyen <ttn@gnuvola.org> writes:

> () "Sean O'Rourke" <sorourke@cs.ucsd.edu>
> () Mon, 23 Jul 2007 17:40:29 -0700
>
>    2007-07-22  Sean O'Rourke <sorourke@cs.ucsd.edu>
>
>            * dabbrev.el (dabbrev--scanning-message): removed.
>            (dabbrev--find-expansion): use a progress reporter
>            instead of dabbrev--scanning-message.
>            (dabbrev--progress-reporter): new variable.
>
> i would like to install this.  rms, is this (see below) suitable
> for immediate ("tiny change") installation or should we ask for
> copyright assignment?

I have sent in a copyright assignment, but this change didn't get
applied because I seemed to be the only person who wanted it.  If
others find it useful, I don't know of other obstacles.

/s

Re: remove dabbrev--scanning-message?

[Richard Stallman]

We have papers from Sean O'Rourke.
I don't object to installing that patch.
(I did object to silencing it entirely.)

Re: remove dabbrev--scanning-message?

[Thien-Thi Nguyen]

() Richard Stallman <rms@gnu.org>
() Wed, 22 Aug 2007 17:27:38 -0400

   We have papers from Sean O'Rourke.
   I don't object to installing that patch.
   (I did object to silencing it entirely.)

thanks.  i have received confirmation from the copyright clerk,
and subsequently installed the change.

thi

Re: remove dabbrev--scanning-message?

[Thien-Thi Nguyen]

() "Sean O'Rourke" <sorourke@cs.ucsd.edu>
() Mon, 23 Jul 2007 17:40:29 -0700

   [progress reporter patch]

copyright assignment confirmed; changes installed.

thi