Dan Nicolaescu <dann@ics.uci.edu> writes:


>   > The patch contains ChangeLog entries.  (The last part of it.)
>
> It is not a good idea to do the add the ChangeLog entry as a diff, it
> rarely still applies cleanly at the time it is checked in.  Include it
> as plain text before that patch, so that it is easier to see what the
> patch is about.

Ok, here's the lisp/ChangeLog entry:

--8<---------------cut here---------------start------------->8---
2007-10-23  Tassilo Horn  <tassilo@member.fsf.org>

	* doc-view.el (doc-view-mode): Remove text/image switching code.
	(doc-view-minor-mode): New minor mode.
	(doc-view-mode-maybe): New function.
	(doc-view-minor-mode-map): New keymap.
	(doc-view-mode-text-map): Remove keymap.
	(doc-view-mode-map): New binding K to kill the converter process.
	(doc-view-current-display): Remove variable.
	(doc-vie w-buffer-message): Mention new binding K.
	(doc-view-displa y-maybe): Remove function.
	(doc-view-pdf/ps->png): Timer calls d-v-display instead
	d-v-display-maybe.
	(doc-view-mode-map): Use image-mode scrolling for mouse-wheel.
	(doc-view-ps->pdf): Resort args to make ps2pdf happy.
	(doc-view-clean-auto-mode-alist): New function.
	(doc-view-current-cache-dir): Better cache dir naming.
	(doc-view-remove-if): New function.
	(doc-view-search-next-match, doc-view-search-previous-match): Use
	it.

	* files.el (auto-mode-alist): Change entries: pdf -> ps-mode, dvi
	-> fundamental-mode.
--8<---------------cut here---------------end--------------->8---

>   > This way it only affects users that want to use doc-view (by
>   > requiring it explicitly).  If we say that it should be loaded by
>   > default, then I agree with you.  But I'm sure there are a lot
>   > people that prefer it not to be loaded by default.
>
> I am not sure I get what you are trying to say. Adding autoloads like
> that will result that code to be loaded by default...

Yes, you're right.  So I removed the autoload cookies there and from
`doc-view-mode-maybe'.