From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: bookmark.el and lisp/gnus/gnus-bookmark.el Date: Fri, 07 Mar 2008 12:08:11 -0500 Message-ID: <87ablamphg.fsf@red-bean.com> References: <874pbj682f.fsf@red-bean.com> <87zltbhbq8.fsf@bzg.ath.cx> <87iqzzigv6.fsf@bzg.ath.cx> <87ejan7xhq.fsf@member.fsf.org> <87hcfi3egg.fsf@bzg.ath.cx> <87abla8w6b.fsf@member.fsf.org> <87bq5qhba6.fsf@bzg.ath.cx> <871w6m8t59.fsf@member.fsf.org> Reply-To: Karl Fogel NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204910053 23306 80.91.229.12 (7 Mar 2008 17:14:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 7 Mar 2008 17:14:13 +0000 (UTC) Cc: Stefan Monnier , Reiner Steib , emacs-devel@gnu.org To: Bastien Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 07 18:14:40 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JXg9W-0006qa-DG for ged-emacs-devel@m.gmane.org; Fri, 07 Mar 2008 18:14:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JXg8y-0007WW-Fg for ged-emacs-devel@m.gmane.org; Fri, 07 Mar 2008 12:14:04 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JXg3M-0002Du-Cx for emacs-devel@gnu.org; Fri, 07 Mar 2008 12:08:16 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JXg3K-0002Ce-Cd for emacs-devel@gnu.org; Fri, 07 Mar 2008 12:08:15 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JXg3K-0002CW-0W for emacs-devel@gnu.org; Fri, 07 Mar 2008 12:08:14 -0500 Original-Received: from sanpietro.red-bean.com ([66.146.193.61]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JXg3J-0002Kh-KW for emacs-devel@gnu.org; Fri, 07 Mar 2008 12:08:13 -0500 Original-Received: from localhost ([127.0.0.1]:39429 helo=floss ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.68) (envelope-from ) id 1JXg3I-0002lJ-8e; Fri, 07 Mar 2008 11:08:12 -0600 In-Reply-To: <871w6m8t59.fsf@member.fsf.org> (Tassilo Horn's message of "Fri, 07 Mar 2008 16:12:50 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:91644 Archived-At: Tassilo Horn writes: >>>> I think you mean: `bookmark-make-cell-function', right? >>> >>> Nope, Karl has renamed it to bookmark-make-record-function. >> >> No, there is both >> >> bookmark-make-record-function (line 466) >> bookmark-make-cell-function (line 741) > > Yeah, but I think Karl missed the second one (make-cell) while renaming. > I've already sent him a mail. Tassilo is right. All my change(s) did was to rename `bookmark-make-cell-function' to `bookmark-make-record-function', which is a better name because it's more suggestive of the actual purpose and less implementation-specific. (I was in the process of also implementing something very similar to what Stefan did, but his commit came in first, so I merged in his changes instead and just did the above variable rename.)