* [BUG] Finternal_merge_in_global_face segfault
@ 2008-07-05 13:34 Johannes Weiner
2008-07-05 15:07 ` Chong Yidong
0 siblings, 1 reply; 5+ messages in thread
From: Johannes Weiner @ 2008-07-05 13:34 UTC (permalink / raw)
To: Chong Yidong; +Cc: Emacs Development Mailing List
Hi,
this change
2008-06-30 Chong Yidong <cyd@stupidchicken.com>
* xfaces.c (Finternal_merge_in_global_face): If default face was
modified, realize it again. Update the font face attribute.
makes Emacs segfault in batch mode.
The culprit is the bcopy(oldface->lface, ...) according to the
stacktrace. I couldn't get gdb to let me inspect oldface (any hints?).
Reverting this change works for me.
Hannes
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUG] Finternal_merge_in_global_face segfault
2008-07-05 13:34 [BUG] Finternal_merge_in_global_face segfault Johannes Weiner
@ 2008-07-05 15:07 ` Chong Yidong
2008-07-05 17:23 ` Johannes Weiner
0 siblings, 1 reply; 5+ messages in thread
From: Chong Yidong @ 2008-07-05 15:07 UTC (permalink / raw)
To: Johannes Weiner; +Cc: Emacs Development Mailing List
Johannes Weiner <hannes@saeurebad.de> writes:
> this change
>
> 2008-06-30 Chong Yidong <cyd@stupidchicken.com>
>
> * xfaces.c (Finternal_merge_in_global_face): If default face was
> modified, realize it again. Update the font face attribute.
>
> makes Emacs segfault in batch mode.
>
> The culprit is the bcopy(oldface->lface, ...) according to the
> stacktrace. I couldn't get gdb to let me inspect oldface (any hints?).
It's probably optimized out. You should recompile Emacs without
optimization (CFLAGS='-g' ./configure; make) and try again.
Please provide a recipe to reproduce this segfault.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUG] Finternal_merge_in_global_face segfault
2008-07-05 15:07 ` Chong Yidong
@ 2008-07-05 17:23 ` Johannes Weiner
2008-07-05 21:16 ` Chong Yidong
0 siblings, 1 reply; 5+ messages in thread
From: Johannes Weiner @ 2008-07-05 17:23 UTC (permalink / raw)
To: Chong Yidong; +Cc: Emacs Development Mailing List
Hi,
Chong Yidong <cyd@stupidchicken.com> writes:
> Johannes Weiner <hannes@saeurebad.de> writes:
>
>> this change
>>
>> 2008-06-30 Chong Yidong <cyd@stupidchicken.com>
>>
>> * xfaces.c (Finternal_merge_in_global_face): If default face was
>> modified, realize it again. Update the font face attribute.
>>
>> makes Emacs segfault in batch mode.
>>
>> The culprit is the bcopy(oldface->lface, ...) according to the
>> stacktrace. I couldn't get gdb to let me inspect oldface (any hints?).
>
> It's probably optimized out. You should recompile Emacs without
> optimization (CFLAGS='-g' ./configure; make) and try again.
I did that (-O0 -g) and could inspect other stuff in this context, not
this. Weird.
> Please provide a recipe to reproduce this segfault.
emacs -batch -f format
Hannes
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUG] Finternal_merge_in_global_face segfault
2008-07-05 17:23 ` Johannes Weiner
@ 2008-07-05 21:16 ` Chong Yidong
2008-07-06 2:15 ` Johannes Weiner
0 siblings, 1 reply; 5+ messages in thread
From: Chong Yidong @ 2008-07-05 21:16 UTC (permalink / raw)
To: Johannes Weiner; +Cc: Emacs Development Mailing List
Johannes Weiner <hannes@saeurebad.de> writes:
>> Please provide a recipe to reproduce this segfault.
>
> emacs -batch -f format
Thanks. I've checked in a fix.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUG] Finternal_merge_in_global_face segfault
2008-07-05 21:16 ` Chong Yidong
@ 2008-07-06 2:15 ` Johannes Weiner
0 siblings, 0 replies; 5+ messages in thread
From: Johannes Weiner @ 2008-07-06 2:15 UTC (permalink / raw)
To: Chong Yidong; +Cc: Emacs Development Mailing List
Hi,
Chong Yidong <cyd@stupidchicken.com> writes:
> Johannes Weiner <hannes@saeurebad.de> writes:
>
>>> Please provide a recipe to reproduce this segfault.
>>
>> emacs -batch -f format
>
> Thanks. I've checked in a fix.
Working! Thanks a lot for the quick fix!
Hannes
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-07-06 2:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-05 13:34 [BUG] Finternal_merge_in_global_face segfault Johannes Weiner
2008-07-05 15:07 ` Chong Yidong
2008-07-05 17:23 ` Johannes Weiner
2008-07-05 21:16 ` Chong Yidong
2008-07-06 2:15 ` Johannes Weiner
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).