From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs/lisp ChangeLog bookmark.el Date: Fri, 21 Nov 2008 14:44:51 -0500 Message-ID: <87abbs6ez0.fsf@red-bean.com> References: Reply-To: Karl Fogel NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1227297351 2285 80.91.229.12 (21 Nov 2008 19:55:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Nov 2008 19:55:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 21 20:56:54 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L3c7W-000120-4M for ged-emacs-devel@m.gmane.org; Fri, 21 Nov 2008 20:56:50 +0100 Original-Received: from localhost ([127.0.0.1]:35479 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L3c6N-0007Py-8F for ged-emacs-devel@m.gmane.org; Fri, 21 Nov 2008 14:55:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L3c6I-0007MW-3F for emacs-devel@gnu.org; Fri, 21 Nov 2008 14:55:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L3c6G-0007Jn-L6 for emacs-devel@gnu.org; Fri, 21 Nov 2008 14:55:33 -0500 Original-Received: from [199.232.76.173] (port=52743 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L3c6G-0007JW-CF for emacs-devel@gnu.org; Fri, 21 Nov 2008 14:55:32 -0500 Original-Received: from sanpietro.red-bean.com ([66.146.193.61]:43096) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L3c6G-0005UW-3Z for emacs-devel@gnu.org; Fri, 21 Nov 2008 14:55:32 -0500 Original-Received: from [127.0.0.1] (port=56995 helo=floss ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.69) (envelope-from ) id 1L3bwZ-0001KD-B0; Fri, 21 Nov 2008 13:46:06 -0600 In-Reply-To: (Stefan Monnier's message of "Fri, 21 Nov 2008 19:29:20 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105910 Archived-At: Stefan Monnier writes: > Modified files: > lisp : ChangeLog bookmark.el > > Log message: > (bookmark-get-bookmark): Add `noerror' arg. > Signal error for invalid bookmark. > (bookmark-get-bookmark-record): Undo last change. > (bookmark-store, bookmark-delete): Use new arg `noerror'. Thanks for doing this. Minor comment below: > Index: bookmark.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/bookmark.el,v > retrieving revision 1.121 > retrieving revision 1.122 > diff -u -b -r1.121 -r1.122 > --- bookmark.el 21 Nov 2008 19:07:24 -0000 1.121 > +++ bookmark.el 21 Nov 2008 19:29:19 -0000 1.122 > @@ -79,6 +79,7 @@ > ;;; Code: > > (require 'pp) > +(eval-when-compile (require 'cl)) What's this part of the change for? (It's not mentioned in the log message, but independently of that, I couldn't tell its purpose.) The rest looked good to me. -Karl