From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: 23.0.92; View-scroll-page-forward/backward does wrong in text mode after text-scale-increase/decrease Date: Sun, 12 Jul 2009 12:44:08 -0400 Message-ID: <87ab39onqf.fsf@stupidchicken.com> References: <87d49v53ba.fsf@cyd.mit.edu> <871von6jjk.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1247417085 23952 80.91.229.12 (12 Jul 2009 16:44:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 12 Jul 2009 16:44:45 +0000 (UTC) Cc: 3361@emacsbugs.donarmstrong.com, duanpanda@gmail.com, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 12 18:44:38 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MQ2AH-0005uu-VG for ged-emacs-devel@m.gmane.org; Sun, 12 Jul 2009 18:44:38 +0200 Original-Received: from localhost ([127.0.0.1]:51678 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MQ2AH-00074e-EI for ged-emacs-devel@m.gmane.org; Sun, 12 Jul 2009 12:44:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MQ2AB-00073e-BJ for emacs-devel@gnu.org; Sun, 12 Jul 2009 12:44:31 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MQ2A6-00071K-5p for emacs-devel@gnu.org; Sun, 12 Jul 2009 12:44:30 -0400 Original-Received: from [199.232.76.173] (port=36399 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MQ2A6-00071D-3O for emacs-devel@gnu.org; Sun, 12 Jul 2009 12:44:26 -0400 Original-Received: from pantheon-po29.its.yale.edu ([130.132.50.124]:37586) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MQ2A5-0000nU-QS for emacs-devel@gnu.org; Sun, 12 Jul 2009 12:44:25 -0400 Original-Received: from furry (c-71-192-161-14.hsd1.nh.comcast.net [71.192.161.14]) (authenticated bits=0) by pantheon-po29.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n6CGiDcC001752 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 12 Jul 2009 12:44:13 -0400 Original-Received: by furry (Postfix, from userid 1000) id 3D808C09B; Sun, 12 Jul 2009 12:44:08 -0400 (EDT) In-Reply-To: <871von6jjk.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 11 Jul 2009 23:39:43 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:112370 Archived-At: Juri Linkov writes: >> View-mode, written in the dawn of time, assumes that all lines have the >> default height. The following patch changes it so that >> scroll-up/scroll-down are passed nil arguments where possible; then >> Emacs will automatically determine how to scroll by one page, taking >> variable-height lines and text-scaling into account. >> >> It's not good to make this kind of change at this stage in the release, >> but this bug would be pretty annoying if you happen to come across it, >> and that's much more likely now we've introduced the text-scaling >> commands. Could someone on emacs-devel help review the patch? > > I noticed that this patch causes a regression: typing RET used to put > point to the last line at the end of the window, but now typing RET keeps > point on the same line. Thanks. This regression isn't serious enough for a fix in the branch, I think (the docstring of View-scroll-line-forward does not say that point should go to the last line). But I'll see what I can do for the trunk.