From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: bookmark.el bug report Date: Mon, 28 Dec 2009 01:48:54 -0500 Message-ID: <87aax361bd.fsf@red-bean.com> References: <5065e2900912272219y3734fc9fsdaee41167ef99ad7@mail.gmail.com> Reply-To: Karl Fogel NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1261982962 31746 80.91.229.12 (28 Dec 2009 06:49:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Dec 2009 06:49:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: Sun Yijiang Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 28 07:49:14 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NP9Pj-0007Yl-5J for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2009 07:49:11 +0100 Original-Received: from localhost ([127.0.0.1]:45624 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NP9Pj-0000TG-FJ for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2009 01:49:11 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NP9PZ-0000R9-Pg for emacs-devel@gnu.org; Mon, 28 Dec 2009 01:49:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NP9PU-0000M2-JQ for emacs-devel@gnu.org; Mon, 28 Dec 2009 01:49:00 -0500 Original-Received: from [199.232.76.173] (port=42364 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NP9PU-0000Lu-E7 for emacs-devel@gnu.org; Mon, 28 Dec 2009 01:48:56 -0500 Original-Received: from sanpietro.red-bean.com ([66.146.206.141]:44591) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NP9PU-0002H1-AS for emacs-devel@gnu.org; Mon, 28 Dec 2009 01:48:56 -0500 Original-Received: from localhost ([127.0.0.1]:54589 helo=floss ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.71) (envelope-from ) id 1NP9PT-0008Ce-4N; Mon, 28 Dec 2009 00:48:55 -0600 In-Reply-To: <5065e2900912272219y3734fc9fsdaee41167ef99ad7@mail.gmail.com> (Sun Yijiang's message of "Mon, 28 Dec 2009 14:19:16 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:118848 Archived-At: Sun Yijiang writes: > `bookmark-bmenu-execute-deletions' is broken for quite some time. I > think I've found the problem. When it calls > `bookmark-bmenu-bookmark', the callee gets text property at > `(line-begging-position)', which is incorrect in this context. Below > is the patched code of `bookmark-bmenu-bookmark' that works for me: > > (defun bookmark-bmenu-bookmark () > "Return the bookmark for this line in an interactive bookmark list buffer." > (when (bookmark-bmenu-check-position) > (let ((pos (line-beginning-position))) > (when (looking-back "^[^ ]") > (setq pos (+ 1 pos))) > (get-text-property pos 'bookmark-name-prop)))) Thank you -- I will take a look! -Karl