From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: bookmark.el bug report Date: Sat, 02 Jan 2010 00:15:09 -0500 Message-ID: <87aawx9jfm.fsf@red-bean.com> References: <5065e2900912272219y3734fc9fsdaee41167ef99ad7@mail.gmail.com> <87r5q99jv9.fsf@red-bean.com> Reply-To: Karl Fogel NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1262409327 22281 80.91.229.12 (2 Jan 2010 05:15:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Jan 2010 05:15:27 +0000 (UTC) Cc: emacs-devel@gnu.org To: Sun Yijiang Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 02 06:15:19 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NQwKc-0005B9-Ek for ged-emacs-devel@m.gmane.org; Sat, 02 Jan 2010 06:15:18 +0100 Original-Received: from localhost ([127.0.0.1]:43549 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQwKc-0004T6-T9 for ged-emacs-devel@m.gmane.org; Sat, 02 Jan 2010 00:15:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NQwKZ-0004SK-E4 for emacs-devel@gnu.org; Sat, 02 Jan 2010 00:15:15 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NQwKU-0004RB-RD for emacs-devel@gnu.org; Sat, 02 Jan 2010 00:15:14 -0500 Original-Received: from [199.232.76.173] (port=48922 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQwKU-0004R8-Kq for emacs-devel@gnu.org; Sat, 02 Jan 2010 00:15:10 -0500 Original-Received: from sanpietro.red-bean.com ([66.146.206.141]:42276) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NQwKU-0004od-N9 for emacs-devel@gnu.org; Sat, 02 Jan 2010 00:15:10 -0500 Original-Received: from localhost ([127.0.0.1]:48719 helo=floss ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.71) (envelope-from ) id 1NQwKT-0005vd-Nz; Fri, 01 Jan 2010 23:15:09 -0600 In-Reply-To: <87r5q99jv9.fsf@red-bean.com> (Karl Fogel's message of "Sat, 02 Jan 2010 00:05:46 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.90 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:119256 Archived-At: Karl Fogel writes: >------------------------------------------------------------ >revno: 99229 >revision-id: kfogel@red-bean.com-20100102043617-3bbh6lg62a8ycsa2 >parent: lekktu@gmail.com-20100102010911-q2hnd1wl2vqgfgb0 >committer: Karl Fogel >branch nick: trunk >timestamp: Fri 2010-01-01 23:36:17 -0500 >message: > * lisp/bookmark.el: Improvements suggested by Drew Adams: > (bookmark-bmenu-ensure-position): New name for > `bookmark-bmenu-check-position'. Just ensure the position; > don't return any meaningful value. > (bookmark-bmenu-header-height, bookmark-bmenu-marks-width): New constants. And if I could edit the commit message for this one, I'd add: (everywhere): Adjust former callers of `bookmark-bmenu-check-position' to call `bookmark-bmenu-ensure-position' instead, and to not use the return value. Sigh. I don't miss CVS, but being able to fix log messages is nice. -K