unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: kill-ring visualization
Date: Thu, 25 Mar 2010 19:29:57 +0200	[thread overview]
Message-ID: <87aatwv12t.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwvbped4za7.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 24 Mar 2010 09:54:58 -0400")

> If you use a `substring' style completion, you're already closer (tho
> it's not a regexp-search).

Is the below what you mean?

I remember there were requests to reuse M-y to complete on the kill-ring
instead of signalling an error that the previous command was not a yank.

=== modified file 'lisp/simple.el'
--- lisp/simple.el	2010-03-23 23:25:12 +0000
+++ lisp/simple.el	2010-03-25 17:29:27 +0000
@@ -3216,9 +3216,21 @@ (defun yank-pop (&optional arg)
 When this command inserts killed text into the buffer, it honors
 `yank-excluded-properties' and `yank-handler' as described in the
 doc string for `insert-for-yank-1', which see."
-  (interactive "*p")
+  (interactive
+   (list
+    (if (not (eq last-command 'yank))
+	(let ((completion-styles '(substring)))
+	  (completing-read "Yank from kill-ring: " kill-ring))
+      (barf-if-buffer-read-only)
+      current-prefix-arg)))
+
   (if (not (eq last-command 'yank))
-      (error "Previous command was not a yank"))
+      (yank (mod (abs (- (length (member arg kill-ring))
+			 (length kill-ring-yank-pointer)
+			 1))
+		 (length kill-ring)))
+
+    ;; Otherwise, if last-command eq 'yank.
   (setq this-command 'yank)
   (unless arg (setq arg 1))
   (let ((inhibit-read-only t)
@@ -3238,7 +3250,8 @@ (defun yank-pop (&optional arg)
 	;; loop would deactivate the mark because we inserted text.
 	(goto-char (prog1 (mark t)
 		     (set-marker (mark-marker) (point) (current-buffer))))))
-  nil)
+    nil))
+
 
 (defun yank (&optional arg)
   "Reinsert (\"paste\") the last stretch of killed text.


PS: This patch is for the demonstration, not for installation.

-- 
Juri Linkov
http://www.jurta.org/emacs/




  parent reply	other threads:[~2010-03-25 17:29 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-18  6:18 kill-ring visualization joakim
2010-03-18 14:06 ` Stefan Monnier
2010-03-18 18:39   ` Leo
2010-03-18 19:37     ` joakim
2010-03-24  9:34   ` Juri Linkov
2010-03-24 13:54     ` Stefan Monnier
2010-03-25  7:04       ` Juri Linkov
2010-03-25  9:47         ` Thierry Volpiatto
2010-03-25 10:13           ` joakim
2010-03-25 10:20             ` Thierry Volpiatto
2010-03-25 13:56               ` anything.el inclusion (was: kill-ring visualization) Ted Zlatanov
2010-03-25 17:28                 ` anything.el inclusion Juri Linkov
2010-03-26  6:37                   ` Thierry Volpiatto
2010-03-26  7:01                     ` Juri Linkov
2010-03-26  7:22                       ` Thierry Volpiatto
2010-03-26 20:19                         ` Stefan Monnier
2010-03-29 18:32                           ` Ted Zlatanov
2010-03-29 19:34                             ` Thierry Volpiatto
2010-04-03  5:44                               ` Thierry Volpiatto
2010-04-03 13:53                             ` Stefan Monnier
2010-04-03 14:17                               ` Thierry Volpiatto
2010-04-03 19:08                                 ` Stefan Monnier
2010-03-26 17:09                   ` Ted Zlatanov
2010-03-27 19:38                     ` Juri Linkov
2010-03-27 21:35                       ` Johan Busk Eriksson
2010-03-28  7:58                       ` Yoni Rabkin
2010-03-28 17:39                         ` joakim
2010-03-29 18:25                       ` Ted Zlatanov
2010-03-26  2:00         ` regexp completion (was: kill-ring visualization) Stefan Monnier
2010-03-25 17:29       ` Juri Linkov [this message]
2010-03-26  2:53         ` kill-ring visualization Stefan Monnier
2010-03-26  7:09           ` Juri Linkov
2010-03-26 20:17             ` Stefan Monnier
2010-03-27 19:42               ` Juri Linkov
2010-03-27 20:37                 ` Stefan Monnier
2010-03-30 16:07                   ` Juri Linkov
2010-03-30 20:35                     ` Stefan Monnier
2010-03-31 15:04                       ` Juri Linkov
2010-03-25 16:49     ` Drew Adams
2010-03-18 15:16 ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87aatwv12t.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).