From: Michael Albinus <michael.albinus@gmx.de>
To: Jan Moringen <jan.moringen@uni-bielefeld.de>
Cc: emacs-devel@gnu.org
Subject: Re: Inclusion of dbus-proxy
Date: Sun, 22 Aug 2010 18:20:36 +0200 [thread overview]
Message-ID: <87aaoesjor.fsf@gmx.de> (raw)
In-Reply-To: <4045_1282428217_ZZh07312bUcyR.00_1282428214.23884.594.camel@steed.robot-madness> (Jan Moringen's message of "Sun, 22 Aug 2010 00:03:33 +0200")
Jan Moringen <jan.moringen@uni-bielefeld.de> writes:
> Hi,
Hi Jan,
> I recently developed dbus-proxy, a framework that makes accessing remote
> D-Bus objects from Emacs Lisp easier and more transparent than the
I would call it "proxy D-Bus objects". The objects you are using reside
on your local host. Accessing D-Bus objects on a remote host is a
different thing.
> current `dbus-call-method' mechanism. Since I was encouraged to propose
> it for inclusion in Emacs, I'm hereby doing so.
It's a nice idea I really appreciate.
> Let me start with a simple example of how a typical usage of dbus-proxy
> looks:
>
> (let ((device-kit (dbus-proxy-make-remote-proxy
> :system
> "org.freedesktop.DeviceKit"
> "/org/freedesktop/DeviceKit")))
>
> ;; Retrieve the daemon-version property.
> (slot-value device-kit :daemon-version)
> (oref device-kit :daemon-version)
For people not familiar with eieio (like me) it would be helpful to
explain what's happening here.
> + dbus-introspection.el
If such a module exists, dbus-introspection-* functions from dbus.el
could be moved here.
> I am aware of the following problems with respect to the inclusion in
> Emacs:
> + Names:
> + Generated class names tend to be long and ugly and do not follow
> usual Lisp conventions
> + `connect' and `disconnect' may need a `dbus-proxy-' prefix?
Yes. In general, every Lisp package should use its own namespace.
> + The generated class hierarchies only work with the :c3 method
> resolution order which was added to EIEIO upstream a few months ago
> but does not seem to have been merged yet
This shall be solved before adding your package.
> + The unit tests use ert which is also not currently included in Emacs
Maybe you cam move the unit tests to another package?
> + The use of the cl library may or may not be acceptable
You load it only during byte-compilation. That's OK I believe.
> ;;; dbus-introspection.el --- Helper functions for D-Bus introspection
>
> ;; malformed-signature
>
> (intern "malformed-signature")
What is this good for? The first use of an uninterned symbol adds it to
the obarray.
> (defconst dbus-proxy-simple-type-codes
> (defun dbus-proxy-parse-simple-type (string)
> (defun dbus-proxy-parse-composite-type (string)
> (defun dbus-proxy-parse-type-list (string)
There are already signature parsing functions in dbusbind.c. Maybe we
could make them available on Lisp level; this could simplify your code.
Furthermore, since we are in dbus-introspection.el, the functions shall
not be prefixed dbus-proxy-*
> ;;; dbus-proxy.el --- Automatic proxies for remote D-Bus objects
> ;;; Commentary:
> ;;
> ;; Here is a basic example of the intended use:
> ;;
> ;; (let ((epiphany (dbus-proxy-make-remote-proxy
> ;; :session
> ;; "org.gnome.Epiphany"
> ;; "/org/gnome/Epiphany")))
> ;; (open-bookmarks-editor epiphany 0))
You could be a little bit more verbose with the example. I suspect, that
the `dbus-proxy-make-remote-proxy' call declares the function
`open-bookmarks-editor', which has been retrieved as method from an
existing interface at "/org/gnome/Epiphany". The following description
of the algorithm tells it somehow, but it is not obvious.
Maybe you could also contribute a section to dus.texi.
Best regards, Michael.
next prev parent reply other threads:[~2010-08-22 16:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-21 22:03 Inclusion of dbus-proxy Jan Moringen
2010-08-22 14:47 ` joakim
2010-08-22 16:20 ` Michael Albinus [this message]
2010-08-22 21:04 ` Jan Moringen
2010-08-23 13:23 ` Kevin Rodgers
2010-08-23 15:44 ` Michael Albinus
2010-08-24 2:03 ` Jan Moringen
2010-08-24 19:50 ` Michael Albinus
2010-08-24 21:32 ` Chong Yidong
2010-08-24 23:59 ` Tom Tromey
2010-08-26 10:09 ` Michael Albinus
2010-08-25 3:24 ` Jan Moringen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aaoesjor.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=jan.moringen@uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).