From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: bug in copy-directory Date: Wed, 09 Feb 2011 09:32:52 +0100 Message-ID: <87aai58v63.fsf@gmx.de> References: <87ipxaidea.fsf@gmail.com> <878vy59ejz.fsf@stupidchicken.com> <87lj23ickn.fsf@stupidchicken.com> <87sjway8i3.fsf@gmx.de> <87wrll2ebe.fsf@stupidchicken.com> <87hbcot7gq.fsf@gmx.de> <87ei7qrdp0.fsf@gmail.com> <87ipx2dayh.fsf@gmx.de> <87y65yyxfu.fsf@gmail.com> <87d3n8xkeq.fsf@gmail.com> <878vxw6r4m.fsf@gmx.de> <87pqr790b0.fsf@gmail.com> <87oc6r7gjc.fsf@gmx.de> <87ipwz8t92.fsf@gmail.com> <878vxt69k7.fsf@stupidchicken.com> <874o8hbc9q.fsf@gmx.de> <87tygh8ez6.fsf@stupidchicken.com> <87zkq7okvk.fsf@gmx.de> <87oc6myqzn.fsf@stupidchicken.com> <87sjvxznmt.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1297241201 15111 80.91.229.12 (9 Feb 2011 08:46:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 9 Feb 2011 08:46:41 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 09 09:46:37 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pn5h5-00016N-5z for ged-emacs-devel@m.gmane.org; Wed, 09 Feb 2011 09:46:35 +0100 Original-Received: from localhost ([127.0.0.1]:48269 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pn5U9-0005T0-OW for ged-emacs-devel@m.gmane.org; Wed, 09 Feb 2011 03:33:13 -0500 Original-Received: from [140.186.70.92] (port=42031 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pn5Tw-0005SB-QQ for emacs-devel@gnu.org; Wed, 09 Feb 2011 03:33:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pn5Tv-0005N4-Mm for emacs-devel@gnu.org; Wed, 09 Feb 2011 03:33:00 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.22]:38345) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1Pn5Tv-0005ME-EI for emacs-devel@gnu.org; Wed, 09 Feb 2011 03:32:59 -0500 Original-Received: (qmail invoked by alias); 09 Feb 2011 08:32:57 -0000 Original-Received: from p57BB9138.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.145.56] by mail.gmx.net (mp060) with SMTP; 09 Feb 2011 09:32:57 +0100 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1+yNi4+LHGy7nMW/ibBMl5SpfAFfXpcE4nAKxuzVH qnXMDjFkFypp9Z In-Reply-To: <87sjvxznmt.fsf@gmail.com> (Thierry Volpiatto's message of "Wed, 09 Feb 2011 08:13:30 +0100") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 213.165.64.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135789 Archived-At: Thierry Volpiatto writes: > Chong Yidong writes: >> Given that we are well into pretest for 23.3, here are two options: >> >> 1. Keep the code that's in the emacs-23 branch. From now on, >> copy-directory needs a non-nil COPY-AS-SUBDIR arg to get cp-like >> copying, when called from Lisp. In the meantime, users of >> M-x copy-directory will be surprised, but that's life. > Not anymore needed. > >> 2. Revert the code in the emacs-23 branch to what it was in 23.2. >> Change copy-directory on the trunk (probably by flipping the meaning >> of the optional arg, and changing Dired and Tramp accordingly.) > > I think you must fix that for 23.3, copying is important. > >> Any arguments for either choice? > > Finally, COPY-AS-SUBDIR is not needed, to remove it we used a second > function called copy-directory-1 and call copy-directory-1 from dired. > Now with these change the state is: > > So it fail only in one place, copying from dired with ssh method. > Because it seem ssh is the only method that call copy-directory, > so dired call copy-directory-1 but the handler reuse copy-directory. > Otherwise other methods seem to work fine (here default method scpc > tested). It is not only one Tramp method which is broken. Tramp has an own implementation for scp- and rsync-based methods. Everything else fails, because Tramp falls back to the default copy-directory, including such methods like ftp, ssh, su(do), smb. I believe, this is not acceptable. I would vote for continuing with the last patch from Thierry, not committed yet. Maybe it is possible to throw copy-directory-1 away, and to adapt the call of copy-directory in Dired instead of. If this is not possible, we shall fall back to the Emacs 23.2 implementation, which is less broken compared with the current status. Best regards, Michael.