From: Tassilo Horn <tassilo@member.fsf.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: ding@gnus.org, emacs-devel@gnu.org
Subject: Re: lexbind ready for merge
Date: Wed, 30 Mar 2011 16:54:09 +0200 [thread overview]
Message-ID: <87aagcwtf2.fsf@member.fsf.org> (raw)
In-Reply-To: <jwvlizwadhu.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 30 Mar 2011 10:29:42 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> The reason is that in trunk, that function has the signature
>> byte-compile-from-buffer (bytecomp-inbuffer &optional bytecomp-filename)
>> but in the lexbind branch, the optional bytecomp-filename has been
>> removed:
>
>> byte-compile-from-buffer (inbuffer)
>
>> AFAIKS, gnus doesn't use the foo.el file anyway, so basically that arg
>> can be removed. But maybe the `byte-compile-from-buffer' definition in
>> [[S]X]Emacs requires exactly 2 arguments? I don't know...
>
> Why on earth does Gnus need to call byte-compile-from-buffer?
The purpose of the whole dgnushack.el is to figure out the correct
load-path when byte-compiling. But I'm the wrong person to ask why that
messy dance has to be danced... I added the Gnus list to the Cc.
The function definition is
(defun dgnushack-emacs-compile-defcustom-p ()
"Return non-nil if Emacs byte compiles `defcustom' forms.
Those Emacsen will warn against undefined variables and functions used
in `defcustom' forms."
(let ((outbuf (with-temp-buffer
(insert "(defcustom foo (1+ (random)) \"\" :group 'emacs)\n")
(byte-compile-from-buffer (current-buffer) "foo.el"))))
(when outbuf
(prog1
(with-current-buffer outbuf
(goto-char (point-min))
(search-forward " 'foo '(byte-code " nil t))
(kill-buffer outbuf)))))
and its use is in dgnushack's form
(when (dgnushack-emacs-compile-defcustom-p)
(maybe-fbind '(defined-colors face-attribute))
(maybe-bind '(idna-program installation-directory)))
where maybe-[f]bind is declared in lpath.el, whose top level comment is
;; Shut up.
;-)
Bye,
Tassilo
next prev parent reply other threads:[~2011-03-30 14:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 21:44 lexbind ready for merge Stefan Monnier
2011-03-29 23:43 ` Daniel Colascione
2011-03-30 1:22 ` Stefan Monnier
2011-03-30 4:10 ` Daniel Colascione
2011-03-30 11:35 ` Juanma Barranquero
2011-03-30 13:24 ` lexbind: how to replace lexical-let approach to hide secrets (was: lexbind ready for merge) Ted Zlatanov
2011-03-30 21:12 ` lexbind: how to replace lexical-let approach to hide secrets Stefan Monnier
2011-03-30 21:56 ` David Kastrup
2011-03-30 22:29 ` Daniel Colascione
2011-03-31 15:42 ` Ted Zlatanov
2011-04-01 1:31 ` Stephen J. Turnbull
2011-04-01 4:41 ` secret strings (was: lexbind: how to replace lexical-let approach to hide secrets) Ted Zlatanov
2011-04-01 5:52 ` Stephen J. Turnbull
2011-04-01 11:02 ` secret strings Ted Zlatanov
2011-04-01 14:38 ` Stephen J. Turnbull
2011-04-01 15:12 ` Ted Zlatanov
2011-04-01 16:14 ` Stephen J. Turnbull
2011-04-01 20:08 ` Ted Zlatanov
2011-04-01 20:34 ` Stefan Monnier
2011-04-01 21:25 ` Ted Zlatanov
2011-04-01 14:59 ` Stefan Monnier
2011-03-30 15:09 ` lexbind ready for merge Daniel Colascione
2011-03-30 15:20 ` Juanma Barranquero
2011-03-30 14:26 ` Stefan Monnier
2011-03-30 7:28 ` Tassilo Horn
2011-03-30 11:30 ` Eli Zaretskii
2011-03-30 13:10 ` Tassilo Horn
2011-03-30 13:17 ` Ted Zlatanov
2011-03-30 14:29 ` Stefan Monnier
2011-03-30 14:54 ` Tassilo Horn [this message]
2011-03-31 1:02 ` Stephen J. Turnbull
2011-03-30 16:11 ` Lars Magne Ingebrigtsen
2011-03-30 17:10 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aagcwtf2.fsf@member.fsf.org \
--to=tassilo@member.fsf.org \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).