From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Emacs revision #107149 Date: Mon, 13 Feb 2012 22:03:14 +0100 Message-ID: <87aa4m5tv1.fsf@gnus.org> References: <20120210232039.GC4340@acm.acm> <87pqdlbby2.fsf@gnus.org> <20120211195927.GA3969@acm.acm> <87zkcnhjfw.fsf@gnus.org> <20120212222238.GA2810@acm.acm> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1329167013 1487 80.91.229.3 (13 Feb 2012 21:03:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 13 Feb 2012 21:03:33 +0000 (UTC) Cc: bug-cc-mode@gnu.org, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 13 22:03:32 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rx33Z-0006pW-FA for ged-emacs-devel@m.gmane.org; Mon, 13 Feb 2012 22:03:29 +0100 Original-Received: from localhost ([::1]:57267 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rx33Y-0002CW-No for ged-emacs-devel@m.gmane.org; Mon, 13 Feb 2012 16:03:28 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:33785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rx33V-0002CQ-Px for emacs-devel@gnu.org; Mon, 13 Feb 2012 16:03:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rx33T-0005qJ-To for emacs-devel@gnu.org; Mon, 13 Feb 2012 16:03:25 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:36189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rx33T-0005q8-Oo; Mon, 13 Feb 2012 16:03:23 -0500 Original-Received: from 93-41-188-50.ip82.fastwebnet.it ([93.41.188.50] helo=rusty) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Rx33M-0002FP-Ao; Mon, 13 Feb 2012 22:03:16 +0100 In-Reply-To: <20120212222238.GA2810@acm.acm> (Alan Mackenzie's message of "Sun, 12 Feb 2012 22:22:38 +0000") User-Agent: Gnus/5.130002 (Ma Gnus v0.2) Emacs/24.0.93 (gnu/linux) X-MailScanner-ID: 1Rx33M-0002FP-Ao MailScanner-NULL-Check: 1329771796.68648@oToDKNZoc/1AJZH7vHeKgg X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:148579 Archived-At: Alan Mackenzie writes: >> As far as I can tell from the cc-mode code, `c-font-lock-fontify-region' >> unconditionally calls `c-standard-font-lock-fontify-region-function'. >> Furthermore, `c-standard-font-lock-fontify-region-function' doesn't seem >> to be set to anything other than `(default-value >> 'font-lock-fontify-region-function)'. And the variable is not a >> user-level variable, which seems to make the entire tap-dance routine >> here rather ... odd. > >> Why not just call `(default-value 'font-lock-fontify-region-function)' >> unconditionally? > > It's unclean programming, and won't work properly under XEmacs. You may well be right, but looking at the code, I don't really see why. There's one single consumer of `c-standard-font-lock-fontify-region-function'? There's one single place it's set? If it isn't set, the function breaks unconditionally? Or is it set to something else under XEmacs (in code that's not in the Emacs 24 tree)? -- (domestic pets only, the antidote for overdose, milk.) http://lars.ingebrigtsen.no * Sent from my Rome