From: Lars Ingebrigtsen <larsi@gnus.org>
To: Alan Mackenzie <acm@muc.de>
Cc: bug-cc-mode@gnu.org, emacs-devel@gnu.org
Subject: Re: Emacs revision #107149
Date: Mon, 13 Feb 2012 22:03:14 +0100 [thread overview]
Message-ID: <87aa4m5tv1.fsf@gnus.org> (raw)
In-Reply-To: <20120212222238.GA2810@acm.acm> (Alan Mackenzie's message of "Sun, 12 Feb 2012 22:22:38 +0000")
Alan Mackenzie <acm@muc.de> writes:
>> As far as I can tell from the cc-mode code, `c-font-lock-fontify-region'
>> unconditionally calls `c-standard-font-lock-fontify-region-function'.
>> Furthermore, `c-standard-font-lock-fontify-region-function' doesn't seem
>> to be set to anything other than `(default-value
>> 'font-lock-fontify-region-function)'. And the variable is not a
>> user-level variable, which seems to make the entire tap-dance routine
>> here rather ... odd.
>
>> Why not just call `(default-value 'font-lock-fontify-region-function)'
>> unconditionally?
>
> It's unclean programming, and won't work properly under XEmacs.
You may well be right, but looking at the code, I don't really see why.
There's one single consumer of
`c-standard-font-lock-fontify-region-function'? There's one single
place it's set? If it isn't set, the function breaks unconditionally?
Or is it set to something else under XEmacs (in code that's not in the
Emacs 24 tree)?
--
(domestic pets only, the antidote for overdose, milk.)
http://lars.ingebrigtsen.no * Sent from my Rome
next prev parent reply other threads:[~2012-02-13 21:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 23:20 Emacs revision #107149 Alan Mackenzie
2012-02-11 15:56 ` Lars Ingebrigtsen
2012-02-11 18:07 ` Wolfgang Jenkner
2012-02-11 19:59 ` Alan Mackenzie
2012-02-12 20:42 ` Lars Ingebrigtsen
2012-02-12 22:22 ` Alan Mackenzie
2012-02-13 1:00 ` Wolfgang Jenkner
2012-02-13 21:35 ` Alan Mackenzie
2012-02-13 3:15 ` Stefan Monnier
2012-02-13 21:42 ` Alan Mackenzie
2012-02-13 22:18 ` Stefan Monnier
2012-02-13 21:03 ` Lars Ingebrigtsen [this message]
2012-02-13 22:07 ` Alan Mackenzie
2012-02-20 9:51 ` Lars Ingebrigtsen
2012-02-21 15:16 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aa4m5tv1.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=acm@muc.de \
--cc=bug-cc-mode@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).