From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: claudio.bley@gmail.com (Claudio Bley) Newsgroups: gmane.emacs.devel Subject: Re: bzr commit 112856 (Symbol prettify in prog-mode; added to perl-mode, cfengine3-mode, and emacs-lisp-mode) breaks compilation on w32 Date: Wed, 12 Jun 2013 09:14:16 +0200 Message-ID: <87a9mv3inr.wl%claudio.bley@gmail.com> References: <87d2rtggay.wl%claudio.bley@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1371021274 24188 80.91.229.3 (12 Jun 2013 07:14:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Jun 2013 07:14:34 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 12 09:14:34 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UmfGL-00046f-R8 for ged-emacs-devel@m.gmane.org; Wed, 12 Jun 2013 09:14:34 +0200 Original-Received: from localhost ([::1]:36365 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmfGL-0006Pu-BA for ged-emacs-devel@m.gmane.org; Wed, 12 Jun 2013 03:14:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmfGH-0006OM-7S for emacs-devel@gnu.org; Wed, 12 Jun 2013 03:14:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UmfGF-0005Hz-Ot for emacs-devel@gnu.org; Wed, 12 Jun 2013 03:14:29 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:60890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmfGF-0005Hl-Eb for emacs-devel@gnu.org; Wed, 12 Jun 2013 03:14:27 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UmfGD-00040N-Nz for emacs-devel@gnu.org; Wed, 12 Jun 2013 09:14:25 +0200 Original-Received: from 178-24-168-244-dynip.superkabel.de ([178.24.168.244]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 Jun 2013 09:14:25 +0200 Original-Received: from claudio.bley by 178-24-168-244-dynip.superkabel.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 Jun 2013 09:14:25 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 214 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 178-24-168-244-dynip.superkabel.de In-Reply-To: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3.50 (i386-mingw-nt6.1.7601) MULE/6.0 (HANACHIRUSATO) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:160366 Archived-At: At Tue, 11 Jun 2013 08:52:30 -0400, Stefan Monnier wrote: >=20 > > 453 (defconst lisp--prettify-symbols-alist > > 454 '(("lambda" . ?=CE=BB))) >=20 > > Obviously because emacs reads the file with cp1152 by default instead > > of UTF-8. >=20 > I think I just fixed it on the trunk. Thanks, works for me. > > *** No rule to make target `lisp/emacs-lisp/lisp-mode.elc' needed by `D= OC'. > > Shouldn't the compile rules exit early when byte compilation fails? >=20 > Yes (modulo "make -k" obviously). OK, how about ---------------- 8< --------------- 8< -------------------------- diff --git a/lisp/makefile.w32-in b/lisp/makefile.w32-in index f4bbaf3..6c1a49c 100644 --- a/lisp/makefile.w32-in +++ b/lisp/makefile.w32-in @@ -298,12 +298,12 @@ TAGS-LISP-SH: $(lisptagsfiles1) $(lisptagsfiles2) $(l= isptagsfiles3) $(lisptagsfi =20 TAGS-CMD: $(lisptagsfiles1) $(lisptagsfiles2) $(lisptagsfiles3) $(lisptags= files4) - $(DEL) TAGS - for %%d in (. $(WINS_UPDATES)) do $(ETAGS) -a $(lisp)/%%d/*.el + for %%d in (. $(WINS_UPDATES)) do ( $(ETAGS) -a $(lisp)/%%d/*.el || exit = 1 ) =20 TAGS-LISP-CMD: $(lisptagsfiles1) $(lisptagsfiles2) $(lisptagsfiles3) $(lis= ptagsfiles4) - $(DEL) $(DEST)/TAGS-LISP for %%d in (. $(WINS_UPDATES)) do \ - $(ETAGS) -a -o $(DEST)/TAGS-LISP $(lisp)/%%d/*.el + ( $(ETAGS) -a -o $(DEST)/TAGS-LISP $(lisp)/%%d/*.el || exit 1 ) =20 .SUFFIXES: .elc .el =20 @@ -328,29 +328,29 @@ compile: $(lisp)/subdirs.el compile0-$(SHELLTYPE) com= pile1-$(SHELLTYPE) compile2 compile0-CMD: autoloads # -for %%f in ($(lisp) $(WINS)) do for %%g in (%%f\*.elc) do @attrib -r %%g for %%f in ($(COMPILE_FIRST)) do \ - $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not= -done %%f + $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not= -done %%f || exit 1 =20 compile1-CMD: autoloads compile0-CMD for %%f in (. $(WINS_BASIC1)) do for %%g in (%%f/*.el) do \ - $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not= -done %%f/%%g + ( $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-n= ot-done %%f/%%g || exit 1 ) =20 compile2-CMD: autoloads compile0-CMD for %%f in ($(WINS_BASIC2)) do for %%g in (%%f/*.el) do \ - $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not= -done %%f/%%g + ( $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-n= ot-done %%f/%%g || exit 1 ) =20 compile3-CMD: autoloads compile0-CMD for %%f in ($(WINS_BASIC3)) do for %%g in (%%f/*.el) do \ - $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not= -done %%f/%%g + ( $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-n= ot-done %%f/%%g || exit 1 ) =20 compile4-CMD: autoloads compile0-CMD for %%f in ($(WINS_BASIC4) $(WINS_CEDET) term obsolete) do for %%g in (%%= f/*.el) do \ - $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not= -done %%f/%%g + ( $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-n= ot-done %%f/%%g || exit 1 ) =20 compile0-SH: autoloads # for elc in $(lisp)/*.elc $(lisp)/*/*.elc; do attrib -r $$elc; done for el in $(COMPILE_FIRST); do \ echo Compiling $$el; \ - $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not= -done $$el; \ + $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not= -done $$el || exit 1; \ done =20 compile1-SH: autoloads compile0-SH @@ -359,7 +359,7 @@ compile1-SH: autoloads compile0-SH if test -f $$el; \ then \ echo Compiling $$el; \ - $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if= -not-done $$el; \ + $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if= -not-done $$el || exit 1; \ fi \ done; \ done @@ -370,7 +370,7 @@ compile2-SH: autoloads compile0-SH if test -f $$el; \ then \ echo Compiling $$el; \ - $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if= -not-done $$el; \ + $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if= -not-done $$el || exit 1; \ fi \ done; \ done @@ -381,7 +381,7 @@ compile3-SH: autoloads compile0-SH if test -f $$el; \ then \ echo Compiling $$el; \ - $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if= -not-done $$el; \ + $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if= -not-done $$el || exit 1; \ fi \ done; \ done @@ -392,7 +392,7 @@ compile4-SH: autoloads compile0-SH if test -f $$el; \ then \ echo Compiling $$el; \ - $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if= -not-done $$el; \ + $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if= -not-done $$el || exit 1; \ fi \ done; \ done @@ -405,8 +405,8 @@ compile-always: $(lisp)/subdirs.el compile-always-$(SHE= LLTYPE) doit =20 compile-always-CMD: # -for %%f in ($(lisp) $(WINS)) do for %%g in (%%f\*.elc) do @attrib -r %%g - for %%f in ($(COMPILE_FIRST)) do $(emacs) $(BYTE_COMPILE_FLAGS) -f batch-= byte-compile %%f - for %%f in (. $(WINS)) do for %%g in (%%f/*.el) do $(emacs) $(BYTE_COMPIL= E_FLAGS) -f batch-byte-compile %%f/%%g + for %%f in ($(COMPILE_FIRST)) do ( $(emacs) $(BYTE_COMPILE_FLAGS) -f batc= h-byte-compile %%f || exit 1 ) + for %%f in (. $(WINS)) do for %%g in (%%f/*.el) do ( $(emacs) $(BYTE_COMP= ILE_FLAGS) -f batch-byte-compile %%f/%%g || exit 1 ) =20 compile-always-SH: # for elc in $(lisp)/*.elc $(lisp)/*/*.elc; do attrib -r $$elc; done @@ -424,7 +424,7 @@ compile-always-SH: compile-calc: compile-calc-$(SHELLTYPE) =20 compile-calc-CMD: - for %%f in ($(lisp)/calc/*.el) do $(emacs) $(BYTE_COMPILE_FLAGS) -f batch= -byte-compile %%f + for %%f in ($(lisp)/calc/*.el) do ( $(emacs) $(BYTE_COMPILE_FLAGS) -f bat= ch-byte-compile %%f || exit 1 ) =20 compile-calc-SH: for el in $(lisp)/calc/*.el; do \ @@ -593,15 +593,15 @@ install: # since cp does not preserve time stamps install-lisp-SH: cp -f *.el "$(INSTALL_DIR)/lisp" - for dir in $(WINS); do [ -d "$(INSTALL_DIR)/lisp/$$dir" ] || mkdir "$(INS= TALL_DIR)/lisp/$$dir"; done - for dir in $(WINS); do cp -f $$dir/*.el "$(INSTALL_DIR)/lisp/$$dir"; done - for dir in . $(WINS); do cp $$dir/*.elc "$(INSTALL_DIR)/lisp/$$dir"; done + for dir in $(WINS); do [ -d "$(INSTALL_DIR)/lisp/$$dir" ] || mkdir "$(INS= TALL_DIR)/lisp/$$dir" || exit 1; done + for dir in $(WINS); do cp -f $$dir/*.el "$(INSTALL_DIR)/lisp/$$dir" || ex= it 1; done + for dir in . $(WINS); do cp $$dir/*.elc "$(INSTALL_DIR)/lisp/$$dir" || ex= it 1; done =20 install-lisp-CMD: cp -f *.el "$(INSTALL_DIR)/lisp" - for %%f in ($(WINS)) do if not exist "$(INSTALL_DIR)/lisp/%%f" mkdir "$(I= NSTALL_DIR)/lisp/%%f" - for %%f in ($(WINS)) do cp -f %%f/*.el "$(INSTALL_DIR)/lisp/%%f" - for %%f in (. $(WINS)) do cp -f %%f/*.elc "$(INSTALL_DIR)/lisp/%%f" + for %%f in ($(WINS)) do if not exist "$(INSTALL_DIR)/lisp/%%f" ( mkdir "$= (INSTALL_DIR)/lisp/%%f" || exit 1 ) + for %%f in ($(WINS)) do ( cp -f %%f/*.el "$(INSTALL_DIR)/lisp/%%f" || exi= t 1 ) + for %%f in (. $(WINS)) do ( cp -f %%f/*.elc "$(INSTALL_DIR)/lisp/%%f" || = exit 1 ) =20 # WARNING: Do NOT split the part inside $(ARGQUOTE)s into multiple lines as # this can break with GNU Make 3.81 and later if sh.exe is used. ---------------- 8< --------------- 8< -------------------------- But, sure enough, compilation then fails with Compiling textmodes/rst.el In toplevel form: textmodes/rst.el:320:1:Error: Variable binding depth exceeds max-specpdl-si= ze mingw32-make[1]: *** [compile3-SH] Error 1 mingw32-make[1]: Leaving directory `C:/Users/Claudio/src/emacs/lisp' mingw32-make: *** [bootstrap-gmake] Error 2 Is this expected? Should I increase max-specpdl-size somehow? --=20 Claudio