From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Engster Newsgroups: gmane.emacs.devel Subject: Re: Feature freeze Date: Tue, 07 Jan 2014 22:30:44 +0100 Message-ID: <87a9f7zdh7.fsf@engster.org> References: <87d2kmuyxg.fsf@engster.org> <87eh4kzss5.fsf@engster.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1389130268 30833 80.91.229.3 (7 Jan 2014 21:31:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 7 Jan 2014 21:31:08 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 07 22:31:11 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W0eEt-0005qG-5p for ged-emacs-devel@m.gmane.org; Tue, 07 Jan 2014 22:31:07 +0100 Original-Received: from localhost ([::1]:43425 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0eEs-0003Nb-OY for ged-emacs-devel@m.gmane.org; Tue, 07 Jan 2014 16:31:06 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0eEk-0003LW-29 for emacs-devel@gnu.org; Tue, 07 Jan 2014 16:31:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0eEd-0005Ax-9e for emacs-devel@gnu.org; Tue, 07 Jan 2014 16:30:57 -0500 Original-Received: from randomsample.de ([5.45.97.173]:33463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0eEc-0005AQ-VY for emacs-devel@gnu.org; Tue, 07 Jan 2014 16:30:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=szWWLx5D4DWA7wEeyvTz/X4YFMY8ZnMd3zYejhciLdw=; b=h09ikVSsdXhPL9id7uiw55M38cgBVRw1jIJkr95ThlZERlhUxyDWfzEBI/Fdaub1N4TXDUMUsg1K0mmuFHad5d1PFv0TuJ9IUlk+z6OP6b+j/UOJ11Z2Ubd6aTlYfDqd; Original-Received: from dslc-082-083-055-015.pools.arcor-ip.net ([82.83.55.15] helo=spaten) by randomsample.de with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1W0eEb-0006r9-Ao; Tue, 07 Jan 2014 22:30:49 +0100 In-Reply-To: (Stefan Monnier's message of "Mon, 06 Jan 2014 19:19:47 -0500") User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3 (gnu/linux) Mail-Followup-To: Stefan Monnier , emacs-devel@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 5.45.97.173 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:167679 Archived-At: Stefan Monnier writes: >> ;;;###autoload >> @@ -653,7 +659,7 @@ >> (help-fns--compiler-macro function) >> (help-fns--parent-mode function) >> (help-fns--obsolete function) >> - >> + (run-hook-with-args 'help-fns-describe-function-functions function) > > Looks good, but please move help-fns--compiler-macro, > help-fns--parent-mode, help-fns--obsolete to > help-fns-describe-function-functions while you're there. Yes, will do. One more question which I forgot to ask: I did rename `eieio-describe-constructor' and `eieio-describe-generic' to `eieio-help-constructor' and `eieio-help-generic', since they are not interactive anymore but augment an existing help buffer. Those two however had aliases `describe-constructor' and `describe-generic', which I'd like to remove. Would that be OK? I don't think anyone was using those, and calling the normal `describe-function' on a constructor or generic will now give the same information. If you'd like to keep them, I'd simply re-implement them as small wrappers for `describe-function'. -David