unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Kastrup <dak@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: bruce.connor.am@gmail.com, emacs-devel <emacs-devel@gnu.org>
Subject: Re: On tabs and spaces
Date: Thu, 15 Jan 2015 10:57:53 +0100	[thread overview]
Message-ID: <87a91kfjry.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <54B6FA42.6000608@yandex.ru> (Dmitry Gutov's message of "Thu, 15 Jan 2015 02:22:42 +0300")

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 01/15/2015 02:15 AM, Artur Malabarba wrote:
>> Given that `.dir-locals.el' sets `indent-tabs-mode' to nil,
>
> Which one?
>
>> does that
>> mean we prefer spaces for indentation everywhere?
>> And, if so, would it be acceptable to push a commit that simply converts
>> a file from tabs to spaces?
>
> Nope. As per previous discussions, you're only really allowed to
> fix/change indentation in the places you make other, meaningful
> changes to.
>
> Mostly so that 'git blame' returns meaningful results (it has a -w 
> option, but that makes it even slower).

git blame does not spend that much of its time diffing.  Even if the
difference between plain and -w has become larger with Git 2.1+ (simply
because it wastes vastly less time with other endeavors), the bulk of
the run time is likely spent in unpacking files from the repository
rather than comparing them.

If you use a Git version older than 2.1, upgrading might make sense just
because of git blame performance.  The difference is quite noticeable.

-- 
David Kastrup



  parent reply	other threads:[~2015-01-15  9:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14 23:15 On tabs and spaces Artur Malabarba
2015-01-14 23:22 ` Dmitry Gutov
2015-01-15  1:01   ` Artur Malabarba
2015-01-15  9:57   ` David Kastrup [this message]
2015-01-15 10:17     ` Dmitry Gutov
2015-01-15 10:26       ` David Kastrup
2015-01-15 10:43         ` Dmitry Gutov
2015-01-15 11:42           ` David Kastrup
2015-01-16  7:23   ` Stephen Leake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a91kfjry.fsf@fencepost.gnu.org \
    --to=dak@gnu.org \
    --cc=bruce.connor.am@gmail.com \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).