unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ivan Shmakov <ivan@siamics.net>
To: emacs-devel@gnu.org
Subject: Re: Errors in redisplay in eww
Date: Sat, 02 Jan 2016 23:40:18 +0000	[thread overview]
Message-ID: <87a8onwnx9.fsf@violet.siamics.net> (raw)
In-Reply-To: <83y4cbbyid.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 30 Dec 2015 20:08:10 +0200")

>>>>> Eli Zaretskii <eliz@gnu.org> writes:
>>>>> From: Ivan Shmakov  Date: Wed, 30 Dec 2015 14:00:43 +0000

 >>> The face is (nil (:background "#ffffff")), and the problem happens
 >>> when we try to merge its car (which is nil, not a valid face).

 >> If I’m reading the code correctly, the 'face property value is set
 >> to either a font or the value returned by the shr-face-background
 >> function, /or/ the value passed to shr-add-font is prepended to the
 >> current face list.  Could you please try doing, say,
 >> trace-function-background on these two functions and see if the
 >> former ever returns anything suspicious (like the list above; and
 >> for what inputs), or if the latter is ever called with a nil TYPE
 >> argument?

 > The contents of the trace buffer is below.  Does this reveal anything
 > interesting?

	I see nothing suspicious there, alas.  I have also tried
	rendering the HTML code of said Web page with a just built Emacs
	(c988877f), but see no nils in the resulting 'face lists.

	FWIW, the shr-face-background function uses consp where I guess
	face-list-p would be more appropriate.  Still, I see no way it
	could be related to the issue described.

  1796	(defun shr-face-background (face)
  1797	  (and (consp face)
  1798	       (let ((background nil))
  1799		 (dolist (elem face)

[…]

-- 
FSF associate member #7257  http://am-1.org/~ivan/      … 3013 B6A0 230E 334A



      reply	other threads:[~2016-01-02 23:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-29 15:52 Errors in redisplay in eww Eli Zaretskii
2015-12-29 16:16 ` Lars Ingebrigtsen
2015-12-29 17:53   ` Eli Zaretskii
2015-12-30 11:24     ` Lars Magne Ingebrigtsen
2015-12-30 16:06       ` Eli Zaretskii
2016-01-02  5:54         ` Lars Magne Ingebrigtsen
2016-01-02  8:41           ` Eli Zaretskii
2016-01-03  9:19             ` Lars Magne Ingebrigtsen
2016-01-04 19:09               ` Eli Zaretskii
2016-01-09  9:13                 ` Lars Magne Ingebrigtsen
2016-01-09  9:46                   ` Eli Zaretskii
2016-01-09 11:59                     ` Lars Magne Ingebrigtsen
2016-02-04  3:25                     ` Lars Ingebrigtsen
2015-12-30 14:00     ` Ivan Shmakov
2015-12-30 18:08       ` Eli Zaretskii
2016-01-02 23:40         ` Ivan Shmakov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8onwnx9.fsf@violet.siamics.net \
    --to=ivan@siamics.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).