From: Tom Tromey <tom@tromey.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Smie-auto-fill doesn’t respect comment-auto-fill-only-comments
Date: Mon, 29 May 2017 15:20:35 -0600 [thread overview]
Message-ID: <87a85vcqcc.fsf@bapiya> (raw)
In-Reply-To: <jwvfufwd7xt.fsf-monnier+gmane.emacs.devel@gnu.org> (Stefan Monnier's message of "Mon, 22 May 2017 15:12:15 -0400")
> (let (compos comin)
> - ;; If we are not inside a comment and we only auto-fill comments,
> - ;; don't do anything (unless no comment syntax is defined).
> + ;; If we are not inside a comment don't do anything (unless no
> + ;; comment syntax is defined).
> (unless (and comment-start
> - comment-auto-fill-only-comments
> (not (called-interactively-p 'interactive))
> (not (save-excursion
> (prog1 (setq compos (comment-beginning))
Stefan> I think we want to remove the whole test: this `unless` is there
Stefan> specifically in order to do nothing if we're outside of comments and
Stefan> comment-auto-fill-only-comments is non-nil. But now the
Stefan> "comment-auto-fill-only-comments is non-nil" case is already handled
Stefan> outside, so we can just always do the auto-fill as if
Stefan> comment-auto-fill-only-comments were nil.
I looked at this, but I don't really understand this code, and there
were more spots in the function that seemed to be affected by the setq
in the snippet above; so consequently I think someone else ought to do
this, and for my part I'm dropping the patch.
thanks,
Tom
next prev parent reply other threads:[~2017-05-29 21:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 12:04 Smie-auto-fill doesn’t respect comment-auto-fill-only-comments Nikolai Weibull
2017-04-23 19:31 ` Nikolai Weibull
2017-04-25 0:18 ` Ian Dunn
2017-04-30 16:52 ` Tom Tromey
2017-04-30 17:08 ` Stefan Monnier
2017-04-30 17:52 ` Stefan Monnier
2017-05-02 18:57 ` Tom Tromey
2017-05-02 19:18 ` Stefan Monnier
2017-05-03 1:14 ` Ian Dunn
2017-05-21 16:43 ` Tom Tromey
2017-05-21 21:03 ` Stefan Monnier
2017-05-22 6:24 ` Tom Tromey
2017-05-22 19:12 ` Stefan Monnier
2017-05-29 21:20 ` Tom Tromey [this message]
2017-05-30 3:25 ` Stefan Monnier
2017-08-05 20:39 ` Tom Tromey
2017-08-05 20:50 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a85vcqcc.fsf@bapiya \
--to=tom@tromey.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).