From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: some accept-process-output races fixed; Tramp FIXMEs Date: Wed, 16 Jan 2019 09:32:19 +0100 Message-ID: <87a7k1hujw.fsf@gmx.de> References: <46ce72ef-c4cb-1cd1-566a-c305ca92e68c@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1547627473 13529 195.159.176.226 (16 Jan 2019 08:31:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 16 Jan 2019 08:31:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Emacs development discussions To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 16 09:31:09 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gjgbN-0003QP-CX for ged-emacs-devel@m.gmane.org; Wed, 16 Jan 2019 09:31:09 +0100 Original-Received: from localhost ([127.0.0.1]:48681 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjgdU-0005oJ-5E for ged-emacs-devel@m.gmane.org; Wed, 16 Jan 2019 03:33:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjgco-0005oB-HJ for emacs-devel@gnu.org; Wed, 16 Jan 2019 03:32:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjgcm-0005l1-IH for emacs-devel@gnu.org; Wed, 16 Jan 2019 03:32:37 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:47151) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gjgcm-0005bn-6I for emacs-devel@gnu.org; Wed, 16 Jan 2019 03:32:36 -0500 Original-Received: from detlef.gmx.de ([212.86.43.239]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Lq9se-1hEMfV1zm4-00dmP6; Wed, 16 Jan 2019 09:32:21 +0100 In-Reply-To: <46ce72ef-c4cb-1cd1-566a-c305ca92e68c@cs.ucla.edu> (Paul Eggert's message of "Tue, 15 Jan 2019 10:33:43 -0800") X-Provags-ID: V03:K1:T8DOxGXDIouYClQ9eiehtz1LTwoJeLuuuOowRr12SsgyctFip3K wuqJvT5sbxFFRT8yzLHs3BVe6xVAbAYiU7FkIU62xhq5vaLcM/XaNGIsR+G8+7QTn4c5AIh XnSqfWoO9NUZQnOp/OvE8VztNnC9EKknIkrdbg8ekSAEZ8Q+cMdF+DGHKDURUqjG0l7fisP jMZztxNiifOUibn2n8XLg== X-UI-Out-Filterresults: notjunk:1;V03:K0:oKPVSPavUXo=:QNHjvr5Xx1WEDsaI2LMWXN N1nq4lBbjg4SnW8kfMysJPzat9YJjEfoWG6+HpX/HWMMHmFQHs5IXD7zq61IuXs6ay00ZoiFU /o/U0UA0vAAP500moLcp0Eqqk6i4u4Qk9rUKyK/UjTuELJB2W0QIUWSNXVLYbZM0ZcihGRB5b IhqRiFofODHXYD1pWWAZ+7wVhxt1I7PBH5/Wdic9XENlqs4H6fpohYtIQhITrqf5nNOPSKjd4 Vpyon6zBao3tgCviI8+ClCzG08yI7CM4YWI5SmmqPtlcESzdkqwH63XtCbNGl10dbtKUUFJnF aJqMj6vVS2fx3ybMd1GBIc7dJMUrUK5VqRAvUa2uH3glLkCOckWQ8XbOI1urXVc1WvFufzrTg tlJ64b2sly8N/8F8gbK9egCGJ+C6atpkhRSE9D/jj93z/AzpR8EA3giit+EAg1O09fRgw4O41 ruFxZsA83EqD4Fccd6E9kX/0aJ9Uae+NGFHlSNO+wQYRLvdu0kauyNyt2VhA2StjcVLkQHTw4 tupMMmvGPe92ofbqfSxAyFCJFhhlclubXLupzYBn0YbomGpfbwqyl/g2OQPdVa8O+B5Nh4t5s tAtzVRQO0Fd4wf5+4wmmwn5lR9dnDi9vLTc3gL1oylg2X8I1KLrSJFB9K6AwYHFFwtjyFYYjy ueb+XLeWwZ26ybj3lCrCgLyiH1fWcveo4/ZEvTE+mxjRxK3QMGFFM6VoAHCmM3rTyDLAw61Sq xIUhM8AGUH4/z3L7D0IbItbkRU9Y5/G/eUGRDkeDCCcdsqrOhQSEH5myvPv+pBKa7HIn9aWp X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232383 Archived-At: Paul Eggert writes: Hi Paul, > I looked for similar instances of the bug elsewhere in Emacs, > and found what appear to be some instances in Tramp code, along with > some mysterious "0.1"s that may be inadequate attempts to work around > the bug. I installed the attached patch to try to document and fix > this mess, including some FIXMEs about those "0.1"s; I hope Michael or > someone else with Tramp expertise (I don't use Tramp) can take a look > at those FIXMEs and at my other Tramp changes, and perhaps at all > other Tramp uses of accept-process-output and of > tramp-accept-process-output. Thanks for the patch. Yes, occasionally there are some problems with accept-process-output in Tramp, hopefully your patch stabilizes this. Due to these problems, test tramp-test43-asynchronous-requests has been tagged as :unstable. I will observe how it goes on. The 0.1 sec timeout in accept-process-output was not introduced for this reason, IIRC. It shall prevent accept-process-output calls from waiting forever for new process output which won't happen. Tramp was blocked by this, w/o the 0.1 sec timeout. I will go through your other FIXMEs, whether there could be arranged something better. Best regards, Michael.