unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Drew Adams <drew.adams@oracle.com>
Cc: Karl Fogel <kfogel@red-bean.com>, Emacs developers <emacs-devel@gnu.org>
Subject: Re: PATCH: isearch-yank-until-match
Date: Fri, 16 Aug 2019 20:51:16 +0300	[thread overview]
Message-ID: <87a7c980ub.fsf@mail.linkov.net> (raw)
In-Reply-To: <20b318b8-de76-4e51-8089-4c75585ae77b@default> (Drew Adams's message of "Thu, 15 Aug 2019 15:15:28 -0700 (PDT)")

>> > I don't think the patch breaks anything (e.g.
>> > uses of `isearch-yank-internal' or
>> > `isearch-process-search-string'), but I've done
>> > limited testing.
>>
>> Actually it breaks other isearch yank commands.
>
> Care to elaborate?  As I said, I tested it only
> briefly.  Please let us know what breakage you
> found.  I don't doubt you, but that info is not
> actionable.

C-s C-w C-r C-w messes up the search string.
But I believe this could be fixed.

>> But anyway the idea is clear.  I think something
>> like this could be added to isearch, but optionally.
>> It should not change the current default behavior.
>
> What default behavior does it change?
>
> Just what part(s) are you referring to, by "this"?
>
> Yanking up to the match for another search pattern?
> Fixing yanking so it supports also backward search?
>
> Which part(s) do you think should be only optional?

Changing the behavior of yanking in backward search.
C-r C-w is still useful to yank forward like it does now.
I don't remember when needed to yank backward.
Do you use backward yanking often?



  reply	other threads:[~2019-08-16 17:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 21:08 PATCH: isearch-yank-until-match Drew Adams
2019-08-15 18:16 ` Juri Linkov
2019-08-15 22:15   ` Drew Adams
2019-08-16 17:51     ` Juri Linkov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-08-20 22:37 Drew Adams
2019-09-16 21:24 ` Drew Adams
2019-09-17 16:03   ` Karl Fogel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7c980ub.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=kfogel@red-bean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).