From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 305dbc7 2/4: Move description of value to syntax-ppss function. Date: Wed, 30 Oct 2019 16:22:50 +0100 Message-ID: <87a79itfzp.fsf@gnus.org> References: <20191030121649.15369.13207@vcs0.savannah.gnu.org> <20191030121651.BFCF8204DF@vcs0.savannah.gnu.org> <87eeyutgwa.fsf@gnus.org> <333d1d46-ab79-5818-4367-b28ed915aff6@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="76129"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 30 16:23:05 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPpoP-000JfI-Az for ged-emacs-devel@m.gmane.org; Wed, 30 Oct 2019 16:23:05 +0100 Original-Received: from localhost ([::1]:41524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPpoO-0005Tv-1O for ged-emacs-devel@m.gmane.org; Wed, 30 Oct 2019 11:23:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43055) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPpoI-0005Tp-2I for emacs-devel@gnu.org; Wed, 30 Oct 2019 11:22:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPpoF-0000bz-SM for emacs-devel@gnu.org; Wed, 30 Oct 2019 11:22:57 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:52738) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iPpoF-0000Vd-Ko for emacs-devel@gnu.org; Wed, 30 Oct 2019 11:22:55 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPpoB-0008K7-D5; Wed, 30 Oct 2019 16:22:53 +0100 In-Reply-To: <333d1d46-ab79-5818-4367-b28ed915aff6@yandex.ru> (Dmitry Gutov's message of "Wed, 30 Oct 2019 17:13:07 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241626 Archived-At: Dmitry Gutov writes: > Point is, in parse-partial-sexp the *can* be relied upon. Though I'm > not sure how often they are used. Yes, the doc string certainly implies that they can be relied upon if you use that function instead. On the other hand, perhaps I shouldn't have moved it -- parse-partial-sexp is used a lot, too. I was only seeing syntax-ppss everywhere, but I see that it's used less than 2x as much. So perhaps that patch should be reverted anyway. Or have the list in both functions. Or, even better, stop saying (if (nth 5 state) (do-something-incomprehensible) (do-something-else-incomprehensible)) everywhere and just add accessor functions already, so that the code becomes marginally more readable. Because trying to make sense of it now is just too hard, and it doesn't have to be. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no