From: "João Távora" <joaotavora@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: scratch/eldoc-xref-project-gnu-elpa-core-packages b1631cd: Turn Eldoc, Xref and Project into GNU ELPA :core packages
Date: Mon, 11 May 2020 23:36:32 +0100 [thread overview]
Message-ID: <87a72ef6a7.fsf@gmail.com> (raw)
In-Reply-To: <da6717eb-1cdc-2fdf-3a81-cf6d24d1b99d@yandex.ru> (Dmitry Gutov's message of "Tue, 12 May 2020 01:21:43 +0300")
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 12.05.2020 01:12, João Távora wrote:
>> Dmitry Gutov <dgutov@yandex.ru> writes:
>>
>>> On 12.05.2020 00:41, Jo�o T�vora wrote:
>>>> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
>>>> index f5f4092..6be1500 100644
>>>> --- a/lisp/progmodes/project.el
>>>> +++ b/lisp/progmodes/project.el
>>>> @@ -1,6 +1,11 @@
>>>> ;;; project.el --- Operations on the current project -*- lexical-binding: t; -*-
>>>> ;; Copyright (C) 2015-2020 Free Software Foundation, Inc.
>>>> +;; Version: 1.0.0
>>>
>>> Please make this one "0.1".
>> No problem, I guess, but sure you don't want "Semantic Versioning"
>> stuff?
>
> I think we should indicate its current pre-release status somehow.
Sounds fair.
>> Also, why only that one ? Any reason why I shouldn't _also_ use
>> 0.1 for eldoc.el and xref.el?
OK
>> Regardless, I have two serious-ish problems here:
>> 1. xref and project.el have a cyclic dependency. xref.el depends
>> (properly) on project.el but it seems project.el also depends on
>> xref.el.
>>
>> (defun project--files-in-directory (dir ignores &optional files)
>> (require 'find-dired)
>> (require 'xref)
>> (defvar find-name-arg)
>>
>> How should I fix this? Any ideas? Or should I be creative?
No idea either. I think it shouldn't be too bad, since the potential
loads happen at runtime. Stefan?
>> 2. It'd be nice if both xref.el and project.el were available for Emacs
>> 26.3. But project.el in Emacs master depends on fileloop.el, which
>> in turn depends on generator.el. OK? Should I make both fileloop.el
>> and generator.el :core packages, too?
>
> fileloop is new, but generator.el has been there since Emacs 25, IIUC.
Unfortunately fileloop.el requires a generator.el variable that is not
in the generator.el of Emacs 26.3, iter-empty.
> fileloop could also be an optional dependency, considering it's only
> required by a couple of commands.
Works for me! But then the comment up there should read:
;;; project.el --- Operations on the current project -*- lexical-binding: t; -*-
...
;; Package-Requires: ((emacs "26.3"))
;; This is a GNU ELPA :core package. Don't use functionality that is
;; not compatible with the version of Emacs recorded above, or avoid
;; that such functionality is compiled by default in that version.
Which would make this a question of an eval-when-compile + some version
check. Unfortunately, the two definitions
;;;###autoload
(defun project-search (regexp)
;;;###autoload
(defun project-query-replace-regexp (from to)
Are autoloaded, as you can see. Maybe I can just make the definitions
fail.
João
next prev parent reply other threads:[~2020-05-11 22:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200511214134.32634.30981@vcs0.savannah.gnu.org>
[not found] ` <20200511214135.F14AF20A23@vcs0.savannah.gnu.org>
2020-05-11 21:54 ` scratch/eldoc-xref-project-gnu-elpa-core-packages b1631cd: Turn Eldoc, Xref and Project into GNU ELPA :core packages Dmitry Gutov
2020-05-11 22:12 ` João Távora
2020-05-11 22:21 ` Dmitry Gutov
2020-05-11 22:36 ` João Távora [this message]
2020-05-11 23:17 ` Stefan Monnier
2020-05-11 23:25 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a72ef6a7.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).