From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?Q?Omar_Antol=C3=ADn_Camarena?= Newsgroups: gmane.emacs.devel Subject: Re: vertical fido-mode Date: Wed, 10 Jun 2020 19:55:09 -0500 Message-ID: <87a71apgk2.fsf@penguin> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="38624"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 11 04:25:39 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jjCuR-0009wc-11 for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Jun 2020 04:25:39 +0200 Original-Received: from localhost ([::1]:46608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjCuO-0001K6-SO for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Jun 2020 22:25:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjBV2-0001w2-4A for emacs-devel@gnu.org; Wed, 10 Jun 2020 20:55:20 -0400 Original-Received: from gauss.matem.unam.mx ([132.248.17.1]:56214) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jjBV0-00077c-7z for emacs-devel@gnu.org; Wed, 10 Jun 2020 20:55:19 -0400 Original-Received: from penguin (unknown [187.170.50.210]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: omar) by gauss.matem.unam.mx (Postfix) with ESMTP id D059454220 for ; Wed, 10 Jun 2020 19:55:12 -0500 (CDT) Received-SPF: pass client-ip=132.248.17.1; envelope-from=omar@matem.unam.mx; helo=gauss.matem.unam.mx X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 20:55:13 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Mailman-Approved-At: Wed, 10 Jun 2020 22:24:56 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252101 Archived-At: Hi! I'm the author of icomplete-vertical. I'd be very happy to see the icom= plete-vertical functionality included in Emacs, and Ergus is completely cor= rect: > But as I see the code in icomplete-vertical-mode; it relies in a hook (ic= omplete-vertical-minibuffer-setup) and an advice (icomplete-vertical-format= -completions) which in principle we don't need with a very simple modificat= ion of icomplete-completions and icomplete-minibuffer-setup. If icomplete-c= ompletions produces the formated output it will be more efficient and clean= than adding an advice or do a reformat. That's exactly what should be done: not include the icomplete-vertical pack= age as is, but instead make small modifications of the existing icomplete p= ackage to incorporate the changes. > There are also some customizable options that for a simple working vertic= al mode we shouldn't need (like icomplete-vertical-separator-alist or a fac= e icomplete-vertical-separator) unless we want to add them now. Again, Ergus is completely right! Those, with the benefit of hindsight, are= over-engineered and shouldn't be included in Emacs. Heck, they shouldn't e= ven be in icomplete-vertical. (I've learned that lesson and although I subs= equently wrote a few more completion UIs, I didn't include options analogou= s to those.) --=20 Omar Antol=C3=ADn Camarena