From: "Omar Antolín Camarena" <omar@matem.unam.mx>
To: emacs-devel@gnu.org
Subject: Re: vertical fido-mode
Date: Wed, 10 Jun 2020 19:55:09 -0500 [thread overview]
Message-ID: <87a71apgk2.fsf@penguin> (raw)
Hi! I'm the author of icomplete-vertical. I'd be very happy to see the icomplete-vertical functionality included in Emacs, and Ergus is completely correct:
> But as I see the code in icomplete-vertical-mode; it relies in a hook (icomplete-vertical-minibuffer-setup) and an advice (icomplete-vertical-format-completions) which in principle we don't need with a very simple modification of icomplete-completions and icomplete-minibuffer-setup. If icomplete-completions produces the formated output it will be more efficient and clean than adding an advice or do a reformat.
That's exactly what should be done: not include the icomplete-vertical package as is, but instead make small modifications of the existing icomplete package to incorporate the changes.
> There are also some customizable options that for a simple working vertical mode we shouldn't need (like icomplete-vertical-separator-alist or a face icomplete-vertical-separator) unless we want to add them now.
Again, Ergus is completely right! Those, with the benefit of hindsight, are over-engineered and shouldn't be included in Emacs. Heck, they shouldn't even be in icomplete-vertical. (I've learned that lesson and although I subsequently wrote a few more completion UIs, I didn't include options analogous to those.)
--
Omar Antolín Camarena
next reply other threads:[~2020-06-11 0:55 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 0:55 Omar Antolín Camarena [this message]
2020-06-11 13:03 ` vertical fido-mode Ergus
2020-06-11 13:44 ` Omar Antolín Camarena
2020-06-11 14:07 ` Ergus
2020-06-11 17:29 ` Basil L. Contovounesios
2020-06-18 13:51 ` Stefan Monnier
2020-06-29 14:44 ` Ergus
[not found] <mailman.50.1591891219.14559.emacs-devel@gnu.org>
2020-06-11 17:06 ` Andrew Schwartzmeyer
[not found] <1704199899.1577092.1591806438580.ref@mail.yahoo.com>
2020-06-10 16:27 ` Ergus
2020-06-10 16:53 ` Stefan Monnier
2020-06-10 19:01 ` Dmitry Gutov
2020-06-10 19:45 ` Basil L. Contovounesios
2020-06-10 21:54 ` Ergus
2020-06-10 22:00 ` Dmitry Gutov
2020-06-10 23:08 ` Juri Linkov
2020-06-10 23:23 ` Dmitry Gutov
2020-06-11 13:22 ` Ergus
2020-06-11 13:28 ` Noam Postavsky
2020-06-11 13:40 ` Ergus
2020-06-11 15:49 ` Protesilaos Stavrou
2020-06-11 15:52 ` Omar Antolín Camarena
2020-06-11 17:37 ` Basil L. Contovounesios
2020-06-17 21:50 ` Juri Linkov
2020-06-17 21:57 ` Dmitry Gutov
2020-06-17 22:17 ` João Távora
2020-06-17 22:31 ` Drew Adams
2020-06-17 22:40 ` João Távora
2020-06-17 22:56 ` Drew Adams
2020-06-17 22:52 ` Juri Linkov
2020-06-17 23:20 ` Drew Adams
2020-06-17 22:22 ` Juri Linkov
2020-06-17 22:52 ` Dmitry Gutov
2020-06-17 22:57 ` Dmitry Gutov
2020-06-17 22:58 ` Drew Adams
2020-06-17 23:15 ` Drew Adams
2020-06-18 21:54 ` Juri Linkov
2020-06-18 22:41 ` João Távora
2020-06-18 22:51 ` Juri Linkov
2020-06-19 8:53 ` João Távora
2020-06-18 8:22 ` Kévin Le Gouguec
2020-06-18 10:19 ` Ergus
2020-06-11 13:10 ` Ergus
2020-08-19 12:17 ` Ergus via Emacs development discussions.
2020-08-20 0:35 ` Juri Linkov
2020-08-20 10:37 ` Ergus
2020-08-20 23:15 ` Juri Linkov
2020-08-21 0:05 ` Ergus
2020-08-23 18:45 ` Juri Linkov
2020-06-10 19:45 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a71apgk2.fsf@penguin \
--to=omar@matem.unam.mx \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).