From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: master 64e25cd: More robust NS hex colour string parsing Date: Fri, 12 Jun 2020 19:15:46 +0000 Message-ID: <87a718w0wt.fsf@gmail.com> References: <20200608120746.30163.87810@vcs0.savannah.gnu.org> <20200608120747.80E8E20A2E@vcs0.savannah.gnu.org> <83r1uk429y.fsf@gnu.org> <3C92A091-F389-4179-B2F0-B3AA5ABD6CCE@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="125541"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 12 21:17:05 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jjpAn-000WWi-O1 for ged-emacs-devel@m.gmane-mx.org; Fri, 12 Jun 2020 21:17:05 +0200 Original-Received: from localhost ([::1]:34110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjpAm-0008WR-QC for ged-emacs-devel@m.gmane-mx.org; Fri, 12 Jun 2020 15:17:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjp9t-0006sc-Je for emacs-devel@gnu.org; Fri, 12 Jun 2020 15:16:09 -0400 Original-Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]:43552) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jjp9r-0000hj-VE; Fri, 12 Jun 2020 15:16:09 -0400 Original-Received: by mail-qv1-xf30.google.com with SMTP id dp10so4858930qvb.10; Fri, 12 Jun 2020 12:15:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=pVhzdNW8SXC8KjBp2NewWBKqlINn9hj6o/T2f/Ulucs=; b=CgBdTA6Ch7gd5VLVnvfS0sfEE+ADS+RsgPT5Rf85WnpKQHO+OOYNmgZ3IJmyUmjiVq 8Q5HqVJ9+JQ1/ZExcEN4ndvzcLAvXBjw4FVJgaViWm/KJi3C45nj058Z+LxnOaNaNbjG 0FLJBMV2encP7p8iX7iQPT6RM+fmGYPo/CJH7ulIhnjH9P9ouGhgkIBIHYX5k8jFeBZf Oo58lgQ1QmxBDbXFuBvyTz2/nAusck//o+wqjNLwdbvktSbkAFDCeBJGFH/F3Ojl2ED5 OJalXTUzG//UmmSuUfnYKVxyOUS/dbFQE6in7Q1L1Lc7KQVGqubf8HYTronXAixVUj7L B7xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=pVhzdNW8SXC8KjBp2NewWBKqlINn9hj6o/T2f/Ulucs=; b=ts5iMWmpZkODjdNffGRAd1kzfaX9Jndegkv6p09rgnYD+XD1Jg/DHqethHIHMmEpOX w6QfBsw9uALC0Pzxxg7BJ3nnMzZafoJ6F63g9zBrTD0Pj1gbHk8efgwtWJXHkUg2tb8s dKz/gFqIQN9H63uxYrlza0kQ8CKiD6oWaxGBk/FOs+jL3tcDaTpWoGPJQz17Ucp0DiZG FGh7B9RYpoSHqRI4QnPgYCz9DVKeBmvXJ0YomLlljpOR9AGXU5S9D1W5vsQBImNmo7V5 /R/FubMAUBIvE20uXfs/WpTfgoodXIJ1943cZ3UO+U9rxgmpCQ2HWrSP0gO/dHzgPGYU 2zHQ== X-Gm-Message-State: AOAM532JFkv0swtblbvUr/0E2+NzMzQfC0eNVmsT7Y2qM15bGBt6ZMG3 Ue3Ukow27PBbdyAmjHwsjIcKH8yyGmd2yA== X-Google-Smtp-Source: ABdhPJxhjRwk7X6qeuYb7lOBaRX8x+4Sks3CWZF6Fsj5d5m9EngbXVeEPKMI7FxMNEhMIBNGd4NNNg== X-Received: by 2002:a0c:f1c7:: with SMTP id u7mr14299801qvl.181.1591989354382; Fri, 12 Jun 2020 12:15:54 -0700 (PDT) Original-Received: from chametz ([185.220.101.199]) by smtp.gmail.com with ESMTPSA id d9sm5153302qtq.56.2020.06.12.12.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2020 12:15:53 -0700 (PDT) In-Reply-To: <3C92A091-F389-4179-B2F0-B3AA5ABD6CCE@acm.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Fri, 12 Jun 2020 21:00:10 +0200") Received-SPF: pass client-ip=2607:f8b0:4864:20::f30; envelope-from=pipcet@gmail.com; helo=mail-qv1-xf30.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252147 Archived-At: Mattias Engdeg=C3=A5rd writes: > 12 juni 2020 kl. 19.33 skrev Eli Zaretskii : > >> Were the 4 versions identical or different? If the latter, what were >> the differences, and which of the features that call them will from >> now on behave differently? > > They were not semantically equivalent but clearly intended to be. Only quite recently; the X version was changed to use the standard scaling convention (#fff means white) a while back, and at the time I preferred the approach of still letting Xlib handle the request, and passing through whatever nonsensical values we might have gotten after the '#' verbatim. That said, I think there's currently a standard interpretation of 16-bit color values (sRGB or something close enough), and I see no harm in your proposed change provided that this is so (I think it's probably a good idea to have things in one place so we can change it to a better color representation once the technology is there. L-a-b is essentially equivalent to RGB, except the components may be negative (not all of them, obviously), so if we move to using three floats for representing a color, they shouldn't be required to be strictly in the [0,1] range.)