From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 4d00db5 8/8: Remove compat code from comint.el Date: Wed, 12 Aug 2020 13:03:09 +0200 Message-ID: <87a6z0p1n6.fsf@gnus.org> References: <20200811190418.24261.58579@vcs0.savannah.gnu.org> <20200811190422.0409E20CB8@vcs0.savannah.gnu.org> <87364sgw3s.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32046"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 12 13:04:00 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5oY3-0008Cw-6s for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Aug 2020 13:03:59 +0200 Original-Received: from localhost ([::1]:38748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5oY2-0002bI-7z for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Aug 2020 07:03:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5oXU-0002Bb-UT for emacs-devel@gnu.org; Wed, 12 Aug 2020 07:03:24 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:33378) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5oXS-0000Sp-QB for emacs-devel@gnu.org; Wed, 12 Aug 2020 07:03:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Usbbo5IOwzPiGQqNTrq9rebBePcyXYI1BJam7ca0FQs=; b=fDCqjmJnypbV4UGjJ/o6WsyXvR tck1K2CL7I1RzwAEsRa/xTljMPcJAwMgVYOXef/EGXkrQBHikw6dE+zrYRHYfu7uNYkp3G99CwXUm WRWgDAwX7+3VWP1LRMXpq2Im4w5/4bZxHScKyS6h9LybjlUcj6xsVXvvvCVn+KNm5JkM=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5oXG-0008H6-R2; Wed, 12 Aug 2020 13:03:18 +0200 In-Reply-To: <87364sgw3s.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 12 Aug 2020 08:29:59 +0100") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253675 Archived-At: "Basil L. Contovounesios" writes: >> Return the (possibly newly created) process buffer." >> - (or (fboundp 'start-file-process) >> - (error "Multi-processing is not supported for this system")) [...] > Perhaps the code here and in the previous commit meant to check for > (fboundp 'make-process) instead? start-file-process may always be > defined, but I don't recall all platforms supporting subprocesses. Or > is this check no longer deemed necessary? Yeah, that makes more sense. There was an equivalent check in esh-proc.el that added a lot of code to the non-start-file-process case that made me wonder, too. I guess there's still platforms without subprocess support? DOS? Or is that deprecated? If so, this patch (and the esh-proc.el patch) should be reverted and the checks changed. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no