From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 262d0c6: Mark some tests as expensive Date: Sat, 12 Sep 2020 13:15:06 +0200 Message-ID: <87a6xv456t.fsf@gnus.org> References: <20200910182904.20559.25935@vcs0.savannah.gnu.org> <20200910182905.F0E4520A2E@vcs0.savannah.gnu.org> <877dt0is0p.fsf@gmx.de> <83a6xve0vq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1940"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: stefan@marxist.se, emacs-devel@gnu.org, michael.albinus@gmx.de, Daniel =?utf-8?Q?Mart=C3=ADn?= To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 12 13:15:54 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kH3VZ-0000Ni-6Y for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Sep 2020 13:15:53 +0200 Original-Received: from localhost ([::1]:35862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kH3VY-0007NE-8r for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Sep 2020 07:15:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH3V0-0006tg-UM for emacs-devel@gnu.org; Sat, 12 Sep 2020 07:15:18 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:50564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH3Uz-0005Wl-8g; Sat, 12 Sep 2020 07:15:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QM6R+iJFJKqqjSFsyvQcKUsaE1txNjTx8WhxwD2T9iY=; b=bxrl5BzchV8toKFxEnCY6+5Ig1 Ulmt9d6tL/HjlDaqxNET0B2J1oNLzfv7UE4ItUNzWq2KSyXhsnzpjuKTgun6znk96RdwJRr3zujAY WhTwMrXFIS8kL8W0NJxmTIWPoM8uL+aF3lQK7GSLRAr/EobeJTg2Jk5JQJBzV9GGelYU=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kH3Uq-0005kp-Cn; Sat, 12 Sep 2020 13:15:13 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXLtaDx6+OIXEnM qU7////Dgg/GAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QJDAsIK273slQAAAHCSURBVDjLZZQN0q4g CIVRN4C1AS9ugGT/e/sOouU712aq8Qnk5xARU00ifTz1ZxFx4yxYjYnSAZhankBuo9NCqY25b1jP 6UrJt3M3G13rJW3aJyowGCoDFjKBTPCP/DHScmWHK+u5w0KG/R6CELlImwbyc3hJbBHUkN4OIO0W gSubQZ/A1xAk6s8DRHYe+Lx/AOHazInsQcE+0N2Rr24PPP4PSEyzpNcXIZp1TB9ZHgBnzAC2jvcy hkEKiwOcJTHrq6ASILHbwBWqbWVbmBEntNUBOqG3vcAUZSVeoJYD8JsHPN8OFqFVK7ymeiMX/6S/ hGqxB28WxwOof+hgplNH9/wHAsT1BPB1ywQdgoHJAS4L0KdYNATnt2yrjtguAZBoZbQLH8e+A16H F7p8MzSnrjuegLvefSluJU8+BsSqvLfI78kLSTiKNG1QzDitfmiqmsoGRd9GoQKGsFy7RlZWq2im M2i1qmh5legFkLx7mPaIQE44K7cSmRMdYvBS9VWSYh/wKK5t8QmIZleuFsMgIaCYcxdkbk2WtFL1 PwQuqAVVX5KT2CdHmJes3qQ5JPapPfojlJu/7oLsGcR4YIF9qv4DhcN+HZa5VD0AAAAldEVYdGRh dGU6Y3JlYXRlADIwMjAtMDktMTJUMTE6MDg6NDMrMDA6MDA0NXlvAAAAJXRFWHRkYXRlOm1vZGlm eQAyMDIwLTA5LTEyVDExOjA4OjQzKzAwOjAwRWjB0wAAAABJRU5ErkJggg== X-Now-Playing: Joni Mitchell's _Joni Mitchell_: "Night In The City" In-Reply-To: <83a6xve0vq.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 12 Sep 2020 13:38:01 +0300") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255300 Archived-At: Eli Zaretskii writes: > I also don't understand the more general issue with how long the test > suite runs. While it runs, you can do something useful on a modern > system (or just go for a coffee), so why does it matter? I appreciate a fast test suite -- I often do a "make check" before pushing just to see that nothing was inadvertently broken by a seemingly-innocuous change. So I think Stefan K's changes here are correct, and that we should have small, fast unit tests only in the default "make check", and have the longer-running integration tests on a different level. (Hydra should run all these, though, and if it doesn't, that should be changed.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no