From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ricardo Wurmus Newsgroups: gmane.emacs.devel Subject: Re: "modern" colors Re: Changes for emacs 28 Date: Mon, 14 Sep 2020 21:47:13 +0200 Message-ID: <87a6xsxhry.fsf@elephly.net> References: <20200910102000.2t6tsju745xutg7u@Ergus> <20200910110832.ko66gqnqo4l664d6@Ergus> <20200911134225.zhnlq7cdhmu2iraj@Ergus> <20200911221435.go7b5kz2zcvxp2ft@Ergus> <20200912153723.ymnq3i5pugqf7lsy@Ergus> <871rj628mq.fsf@elephly.net> <20200912195358.3zjct7gsogjtlh3n@Ergus> <87y2lezrbp.fsf@elephly.net> <83pn6pbtni.fsf@gnu.org> <87mu1tzlxo.fsf@elephly.net> <83mu1tbp7a.fsf@gnu.org> <87h7s1zccb.fsf@elephly.net> <878sddz72o.fsf@elephly.net> <837dswbept.fsf@gnu.org> <87r1r4xq74.fsf@elephly.net> <83imcg9shm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24122"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.13; emacs 27.1 Cc: spacibba@aol.com, casouri@gmail.com, emacs-devel@gnu.org, ams@gnu.org, monnier@iro.umontreal.ca, ghe@sdf.org, tecosaur@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 14 21:47:30 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHuRm-0006B0-12 for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Sep 2020 21:47:30 +0200 Original-Received: from localhost ([::1]:59334 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHuRl-00020L-3c for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Sep 2020 15:47:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHuQP-0000tI-Lp for emacs-devel@gnu.org; Mon, 14 Sep 2020 15:46:05 -0400 Original-Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21140) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHuQM-00086V-BV; Mon, 14 Sep 2020 15:46:05 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1600112759; cv=none; d=zohomail.com; s=zohoarc; b=MIxgfZNGEm5KWWZqsJa+vlI13oy1IbgHOnb4lKNcbrzLkWY2XThbdyqmzeyOrF8eAAP6uDpbaMwx7jrJKX5emys2s4zIpWnJ0l2iPcltAIWLiqzfnvANCDtFTFl/lE6i9skUf8SB/zW6knudYQHH3L2/T69Df9bjjdcQsadtkrk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600112759; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=aHbZdu2kMyl/vnwGaqSdV+u335ht4yfaozN1/DUgZ/s=; b=IkpXZqXJ2+tvBvHWBJRJUKkQglyhhOJ0402BwWViGQSKIwX8N2K/7XGGGaMJGcGfMFAXg/GahpTK+CAeVWO6Ct3dPp9kSFW+lWGXDkIBixecfhx1+bYNF+EUvDm/FRTQCECOu6DVcFtJxet9CJwS3jJHtWD+BDTBMoNSQvJ3A+s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1600112759; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=aHbZdu2kMyl/vnwGaqSdV+u335ht4yfaozN1/DUgZ/s=; b=ITA0VrLnNabVZGpcXrAVJ3mg8SJ8sPg3MR9nQIseLHqdsSrF0zs5+kzhahtm00Yh C/okKNcUscfw4grSK0w1xAiDivTCyavuF6ZF8LoBBzRlAASWrFe0Adl/5vCC3cU+Om5 uccvTOQymN0pX9myQdKZ/azZXM/ttyPmV3pNyko0= Original-Received: from localhost (p54ad4c23.dip0.t-ipconnect.de [84.173.76.35]) by mx.zohomail.com with SMTPS id 16001127567965.619675137345439; Mon, 14 Sep 2020 12:45:56 -0700 (PDT) In-reply-to: <83imcg9shm.fsf@gnu.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.51; envelope-from=rekado@elephly.net; helo=sender4-of-o51.zoho.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/14 15:46:00 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255689 Archived-At: Eli Zaretskii writes: >> From: Ricardo Wurmus >> Cc: monnier@iro.umontreal.ca, spacibba@aol.com, casouri@gmail.com, >> emacs-devel@gnu.org, ams@gnu.org, ghe@sdf.org, tecosaur@gmail.com >> Date: Mon, 14 Sep 2020 18:45:19 +0200 >>=20 >> > But is it certain that we can only do a partial job here? I don't >> > think so, and the fact that we succeed in producing good results on >> > other platforms is evidence to that. >>=20 >> If we set the region colour according to the GTK colour theme we would >> need to make sure that none of the other faces use a colour that would >> be hard to distinguish from the region colour. To do a complete job >> would require to set the colours in *all* faces according to the GTK >> colour theme. >>=20 >> Just the default colour will do nothing to remove the colour clash >> between e.g. font-lock-comment-face and the region colour. > > How is this different from other platforms we support? This stuff > does work there. It works because, as Stefan points out, Emacs adapts > its face colors to the background color of the default face: we have > separate sets of colors for light and dark backgrounds. I don=E2=80=99t understand. There is a clear problem here in that the font-lock-comment-face is dark red and the region colour is whatever the GTK theme says it should be. So unless font-lock-comment-face is also set according to the GTK theme=E2=80=99s colours there is no way to avoid t= his unfortunate combination of colours (dark red on dark background) without customization. FWIW neither the dark red colour nor the region background colour changes when I change frame-background-mode. --=20 Ricardo