From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] tab-line-alternate-colors Date: Wed, 16 Dec 2020 11:03:51 +0200 Organization: LINKOV.NET Message-ID: <87a6ueruko.fsf@mail.linkov.net> References: <87360autpy.fsf@alphapapa.net> <87mtyiqfzv.fsf@mail.linkov.net> <87tusqt3yr.fsf@alphapapa.net> <87wnxl760u.fsf@mail.linkov.net> <87h7opt3a4.fsf@alphapapa.net> <87blewpwf5.fsf@mail.linkov.net> <878sa0u2hn.fsf@alphapapa.net> <87360847c8.fsf@mail.linkov.net> <878s9yxwjc.fsf@alphapapa.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33377"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 16 10:31:40 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kpT9o-0008cV-Ay for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Dec 2020 10:31:40 +0100 Original-Received: from localhost ([::1]:55832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpT9i-0005CJ-EJ for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Dec 2020 04:31:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpT8T-0004EY-PM for emacs-devel@gnu.org; Wed, 16 Dec 2020 04:30:19 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:52657) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpT8Q-00059a-Jv for emacs-devel@gnu.org; Wed, 16 Dec 2020 04:30:17 -0500 Original-Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 95485240002; Wed, 16 Dec 2020 09:30:09 +0000 (UTC) In-Reply-To: <878s9yxwjc.fsf@alphapapa.net> (Adam Porter's message of "Tue, 15 Dec 2020 21:24:55 -0600") Received-SPF: pass client-ip=217.70.178.230; envelope-from=juri@linkov.net; helo=relay10.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260975 Archived-At: > Ok, I went with option 2, which moves the default-face code from the > -tab-face-default function back into the -format-template function. > > Then I added buffer-p and selected-p arguments to the modifier functions > as optimizations. > > This patch also includes changes for the face-related issues Eli > mentioned, and it renames the -modifiers option to -functions, as you > suggested. > > Please let me know what other changes are required. Also, if I should > write a NEWS entry, let me know and I'll add one. Thanks, everything looks right. The only thing I'm unsure about is the default value. I don't know how important is to highlight the distinction between file and non-file buffers. But it's a matter of taste, so I can't argue against or for a specific default value. Ideally, the default value should reflect preferences of the most users, but even the conducted surveys don't help, as the discussion about the toolbar indicates.