unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Adam Porter <adam@alphapapa.net>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] tab-line-alternate-colors
Date: Wed, 16 Dec 2020 11:03:51 +0200	[thread overview]
Message-ID: <87a6ueruko.fsf@mail.linkov.net> (raw)
In-Reply-To: <878s9yxwjc.fsf@alphapapa.net> (Adam Porter's message of "Tue, 15 Dec 2020 21:24:55 -0600")

> Ok, I went with option 2, which moves the default-face code from the
> -tab-face-default function back into the -format-template function.
>
> Then I added buffer-p and selected-p arguments to the modifier functions
> as optimizations.
>
> This patch also includes changes for the face-related issues Eli
> mentioned, and it renames the -modifiers option to -functions, as you
> suggested.
>
> Please let me know what other changes are required.  Also, if I should
> write a NEWS entry, let me know and I'll add one.

Thanks, everything looks right.  The only thing I'm unsure about is the
default value.  I don't know how important is to highlight the distinction
between file and non-file buffers.  But it's a matter of taste, so
I can't argue against or for a specific default value.  Ideally, the
default value should reflect preferences of the most users, but even the
conducted surveys don't help, as the discussion about the toolbar indicates.



  parent reply	other threads:[~2020-12-16  9:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-13  6:04 [PATCH] tab-line-alternate-colors Adam Porter
2020-12-13  6:17 ` Adam Porter
2020-12-13  8:45 ` Juri Linkov
2020-12-13 10:06   ` Adam Porter
2020-12-13 11:13     ` Adam Porter
2020-12-13 15:21     ` Eli Zaretskii
2020-12-14  2:17       ` Adam Porter
2020-12-14 15:34         ` Eli Zaretskii
2020-12-16  2:58           ` Adam Porter
2020-12-16 15:41             ` Eli Zaretskii
2020-12-13 21:25     ` Juri Linkov
2020-12-14  4:33       ` Adam Porter
2020-12-14  9:10         ` Juri Linkov
2020-12-14 10:05           ` Adam Porter
2020-12-14 19:37             ` Juri Linkov
2020-12-16  3:24               ` Adam Porter
2020-12-16  3:55                 ` Adam Porter
2020-12-16  9:03                 ` Juri Linkov [this message]
2020-12-16 10:26                   ` Adam Porter
2020-12-16 20:46                     ` Juri Linkov
2020-12-18  3:55                       ` Adam Porter
2020-12-23 21:07                         ` Juri Linkov
2020-12-24 11:26                           ` Adam Porter
2020-12-14  9:14         ` Adam Porter
2020-12-14 19:33           ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6ueruko.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=adam@alphapapa.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).