From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master e38e7b7: Make syntax errors say the line/column they appear at Date: Tue, 02 Feb 2021 09:34:42 +0100 Message-ID: <87a6smookd.fsf@gnus.org> References: <20210201161423.6054.53972@vcs0.savannah.gnu.org> <20210201161425.6B83A20DFD@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33857"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 02 09:36:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6rAH-0008fk-Ng for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Feb 2021 09:36:01 +0100 Original-Received: from localhost ([::1]:41168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6rAG-0002Ue-Os for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Feb 2021 03:36:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6r9D-0001x7-FK for emacs-devel@gnu.org; Tue, 02 Feb 2021 03:34:55 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:47920) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6r9B-0002Fb-PP for emacs-devel@gnu.org; Tue, 02 Feb 2021 03:34:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4ALl1bp4I1dShN8SHVEA291y1Am/csueikvdHYPX6VI=; b=kh9Py9bYHc43zLuuPWKc/qj9iZ X1fNDE4QuOy91acNJXWx5BhXDbjbukmFUETeGr+x2iYhzyldwRJ/znllDsoXMOiLiVIbiCTRzbHF4 i9l+rayuoJLnMXT4jokrvxV79qGIfT2LG/wSoD3OVQnVuPSjroi/BNIKsw3wVtWapXIk=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6r92-0002AL-4E; Tue, 02 Feb 2021 09:34:48 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUeFhZcT02KfXPF v73///9esnxvAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UCAggfCnkIDUIAAAGpSURBVDjLldPbEeMw CAVQcBoQqAGDGohR/73tRQ87yX7srCeeZHQMASwR/f8lUgqbFJPvdb46edTw1r/hcCdv6s3bTwRz EaQ6C/9GHAiIMPqBl7N27R3wI6MwEyssf8NRVAZwoc+UpqYiqmioUN67MNdLLUFY+AFhr5e7VBeA ZNYN0cLdFgiy7r/u7WoQ/EbGG9gA0dwygTjqWONkn3ASgVSR0nZNvQMK936Ruuk3RCENAfiO0BjQ CysmmRAfgAsRV6E6IOsoNeoEdqQa4GVGLCDJiPDaB/ATUTMiYaSi2ndEHXcs4H8DN9T5AW3BOcsd IJjODbPBCc7vJ9UpD5SE1mfnp2FWZ0J2fgL2SHJkZcB4t7xndXLERQ9Q8wVUSqHWXaPMzvEG87rG rHvHXp67RJ37CkF4DztsgSW0YYGPHLb2oaHiBVcCbxBKiFx9N4xj73p8o3WNjHl7dl1uUOwrwwlF k9ghA+aRqBNeQWNP7Qi0Uq9mggIQcX6dXLX2ln44vex5fALmjPHTfTYWH6ZvwvagAw/cq3nYTyzI q+NIP6AD8s3Uhjwb/gCH4FjV4e3GmgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0wMi0wMlQwODoz MToxMCswMDowMAgp/2wAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDItMDJUMDg6MzE6MTArMDA6 MDB5dEfQAAAAAElFTkSuQmCC X-Now-Playing: Joe Jackson's _At the BBC (1)_: "T.V. Age" In-Reply-To: (Stefan Monnier's message of "Mon, 01 Feb 2021 14:47:41 -0500") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263710 Archived-At: Stefan Monnier writes: > But, FWIW, I'd much rather that the error object contains "raw data" > rather than "human-readable" data. I.e. something like: > > xsignal2 (Qinvalid_read_syntax, s, PT); > > and then convert the buf-pos to line+column later on, when the error > is displayed. Good idea; now fixed. > [ And if we don't have any ready-made place where we can put > this display-time conversion, then we should probably change that > as well. ] We have the same thing with forward-sexp: Scan error: "Containing expression ends prematurely", 373, 374 which is pretty cryptic, but `M-f' says user-error: No next sexp A general display conversion thing would be nice, but I guess some of the conversions would be context dependent? The invalid-read-syntax line/column one wouldn't be, I think... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no