From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 32e790f: Implement NTLM server for ntlm.el testing Date: Fri, 19 Feb 2021 18:40:54 +0100 Message-ID: <87a6s0vtuh.fsf@gmx.de> References: <20210219014652.27375.17475@vcs0.savannah.gnu.org> <20210219014654.0131020DFB@vcs0.savannah.gnu.org> <877dn48kw8.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18735"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Thomas Fitzsimmons Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 19 18:50:24 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lD9v6-0004lp-DF for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Feb 2021 18:50:24 +0100 Original-Received: from localhost ([::1]:59706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD9v5-0005ZN-1f for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Feb 2021 12:50:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD9m1-0004Pc-Fe for emacs-devel@gnu.org; Fri, 19 Feb 2021 12:41:02 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:56601) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD9ly-00068b-HM for emacs-devel@gnu.org; Fri, 19 Feb 2021 12:41:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1613756455; bh=+H5/MEMPKgecKZ5yGVb5z6E1/mnpvSmNPyDqrMYpzKY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Tr+S1YJ4HpLvJjnL3oxygIB9mruUWdvTPRPFSLXbafCTDZ/MFWv86j21arqyEMZlg +dcyjMk7gB6ACZW+Hywf9Qxn2x7kGSeqinEzy/kYc/aYyRd/pZHqTPNkUJc3G8p7kn Wa1OieKKnR37si/n/gsPQq9mNp28fhfIqaF8EgPY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.145.206]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mqs0X-1lhUZi0Kgr-00moIt; Fri, 19 Feb 2021 18:40:55 +0100 In-Reply-To: (Thomas Fitzsimmons's message of "Fri, 19 Feb 2021 09:13:52 -0500") X-Provags-ID: V03:K1:MGuJjo/lXz5NX794PJyCHmbuA/RGoS7r4Faixm9IIUnxnT5UXUw 5KClnA08K9AOtMHH7NXliluRIdiuQVGgWQIPFZic4BzTCGDzUKMvIvr0dMMIEPYqvp3kWf9 sGl4M58KS45Ydyjg1VKp6G6wwLlQIbA6mo/Q1/Vu6vaVDh/lOv0gnDo+fQKvuNVjV1g/0jc AeufkXq3Hrk5A/p7KsGCw== X-UI-Out-Filterresults: notjunk:1;V03:K0:iCOgqx7/w04=:nZViT4pZ0UmZIIQcSgnfbR nL/ZIY1GEDiRSFhBwkxozQH8ES9okgfDCkRbxK4pKKpsMAkBXzIl4GNlzfgLlQbuaCa7dJSTv HDVRhUUnq5VNTDjXtDW7/rDeT+2PDWqk1MzHBucqVxoilwEJsXK1QFaIOqMuy22aWDXEDKkQ/ M80OO3Qpr1y0/Itmm5i+5oVqitE+UbpOA1Lr4b5kdht4+NpTkIBPlUEc/qNzvU1oIYwNO8Gry FfygzhzIsJEynZrKtarTrujpIIf65t5g1S70d37EZVcyr862hwzpTEMAKF4Sd2G+j6i9Xr/0h X4h53j7pgpJkYvlwo9o6rV2Kp8M/aFJoaBjvGDsENNANo9Wx7Z/kvwv6zMKCKAtKkfWszjCnw eXvDX7djulN5X2PCvJ9+E2fd1CdEphI/8PD44sjXP48+CktrnvyEdfawpZ/cQGK2QeJhy++zs Gn8k5srKOAcw1Hq0BSWFxTCGI6dmlNS1xij/aJ/sw537WzbiNrsOWEFiRXywrZP8BFfxSxLZZ WI/sLsrDKWaytATwclaaJKdt4BiqpODjV6f4iSry/+jmYyM6cOQnvtBzTEE398FspruM97Mb2 KxU6Vz/9vd+MAgt6CaavhcU4WwVv8CGEb3ugZLxJ1Fq7AS5zNI8X4Gx1la3O5jSao9/BkZQ7t Uw5ntj1QwpSILUoEIGq3/GwT9RuKwVuMkkT86oDA0ep/OMid1w9jeWvUNHFuTxehc70OR9rkM Wcp5esrsSihq0bksS/QiU3ImG65SS+nIPLf5GN1XQNTD3Fme9+/3PgTla3xsHCtan4xRwp4x Received-SPF: pass client-ip=212.227.17.21; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265275 Archived-At: Thomas Fitzsimmons writes: Hi Thomas, >> Not a big deal, after pulling and recompiling recent web-server ELPA >> package it was fixed. However, it makes me nervous that a checkout of >> emacs master can fail tests, w/o any reason inside the sources. > > I realize this isn't ideal, but it's better than nothing, i.e., not > being able to use GNU ELPA packages as test dependencies. And if you > expand "inside the sources" to include GNU ELPA, which I assume Emacs > maintainers who have an elpa checkout do, then I think it's OK (maybe > even desirable?) to have to look into GNU ELPA-dependent test failures. Of course I appreciate to use GNU ELPA packages for tests. But you cannot assume that everybody has an ELPA git checkout. Given, that the packages live in their own branches or repositories. > That said, if there is no elpa.git checkout at ../elpa, or if > GNU_ELPA_DIRECTORY=/nonexistent, then the tests are just skipped. There are just three Emacs maintainers, and they might run an ELPA checkout. But ordinary Emacs developers might live w/o an ELPA checkout, and use just packages provided by the default mechanism, and selected by them. We shall be prepared also for this case (and maybe extend the way how GNU ELPA packages are accessed when running the Emacs tests). > (Maybe as a result of the bundling discussions, GNU ELPA will become a > submodule of emacs.git which would make the dependency more reliable.) Maybe. But we aren't at this point yet. And since packages have their own repository life, I doubt that "git pull" from the Emacs repository will bring us also fresh packages checkout. >> Could you pls provide more advanced checks for dependencies? For >> example, instead of >> >> (and (featurep 'url-http-ntlm) (featurep 'web-server)) >> >> you could check a proper version of the packages? > > I'd rather not add the complexity, e.g., depending on package.el. > Beyond this first requirement to update web-server to the latest, I > don't see how a version check would be useful. I tried to implement a > specific check for the ws-parse functionality, but I couldn't find an > easy way of confirming the new NTLM path. That's just *this* case. Other changes might apply to your packages in the future, which require newer package code. And I'm thinking also about a more general approach for other Emacs tests, how to use GNU ELPA packages as dependency. And you don't need package.el. Require lisp-mnt, then you could do something like --8<---------------cut here---------------start------------->8--- (defvar ntlm-tests--dependencies-present (and (featurep 'url-http-ntlm) (version<= "2.0.4" (lm-version (locate-file "url-http-ntlm.el" load-path))) (featurep 'web-server) (version<= "0.1.2" (lm-version (locate-file "web-server.el" load-path)))) "Non-nil if GNU ELPA test dependencies were loaded.") --8<---------------cut here---------------end--------------->8--- >> Warning (emacs): Cannot find one or more GNU ELPA packages >> Warning (emacs): Skipping NTLM authentication tests >> Warning (emacs): See GNU_ELPA_DIRECTORY in test/README >> Running 3 tests (2021-02-19 10:26:00+0100, selector `(not (tag :unstable))') >> skipped 1/3 ntlm-authentication (0.000133 sec) >> skipped 2/3 ntlm-authentication-old-compatibility-level (0.000097 sec) >> passed 3/3 ntlm-time-to-timestamp (0.000136 sec) >> >> Is it necessary to be such chatty? The tests are skipped (like other >> tests), fine. > > I debated not putting in those warnings. I wanted to point out why the > tests are being skipped, and in particular that it's easy to have them > not be skipped if you have a GNU ELPA checkout (versus tests that are > unavoidably skipped because they depend on a different OS or > architecture). > > Basically, I'd like to encourage Emacs maintainers to not skip these > tests; the reason I wrote them was to prevent regressions like Bug#43566 > (merged with Bug#44195 and Bug#44439), which broke all uses of NTLM in > an Emacs point release. Again, not every Emacs developer has an ELPA checkout. And we shouldn't be bossy to them. > Thomas Best regards, Michael.