From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 6458e16: New mode outline-cycle-minor-mode with Orgmode-like TAB cycling on headings Date: Thu, 04 Mar 2021 11:05:29 +0200 Organization: LINKOV.NET Message-ID: <87a6rj44k6.fsf@mail.linkov.net> References: <20210303191236.24697.93201@vcs0.savannah.gnu.org> <20210303191237.2B2D720E1B@vcs0.savannah.gnu.org> <87zgzkug5d.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16939"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Gabriel do Nascimento Ribeiro Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 04 11:17:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHl3F-0004Jc-5A for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 11:17:49 +0100 Original-Received: from localhost ([::1]:55764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHl3E-0004D7-4y for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 05:17:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHl22-0002yD-S7 for emacs-devel@gnu.org; Thu, 04 Mar 2021 05:16:34 -0500 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:52947) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHl1z-0001aL-DB for emacs-devel@gnu.org; Thu, 04 Mar 2021 05:16:34 -0500 X-Originating-IP: 91.129.96.116 Original-Received: from mail.gandi.net (m91-129-96-116.cust.tele2.ee [91.129.96.116]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 36CE940011; Thu, 4 Mar 2021 10:16:27 +0000 (UTC) In-Reply-To: (Gabriel do Nascimento Ribeiro's message of "Wed, 03 Mar 2021 21:31:04 -0300") Received-SPF: pass client-ip=217.70.183.194; envelope-from=juri@linkov.net; helo=relay2-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265938 Archived-At: > This is a great feature, thank you! I could replace all my custom elisp > code that handles outline cycle/highlight on my init.el with the new > minor-modes, and everything has been working fine so far. > > I think that having only the variables is fine, I can't see any special > need for the minor-modes. > >> 4. (advice-add 'xref--insert-xrefs :after >> (lambda (&rest _args) >> (setq-local outline-regexp "/") >> (outline-cycle-minor-mode +1))) >> using file names as headings where S-TAB could provide >> an overview of all found files > > The use of outline-minor-mode + cycle on xref buffers is one of my main > use cases. However, having to setup the outline-regexp and to add a > defadvice seems a dirty hack. Should Emacs provide better defaults for > xref and other modes (like Gnus) for an easier integration with > outline-minor-mode ? Gnus has own outline-like commands like 'T H' that hides all threads. But in xref it should be easy to set the outline-regexp by default, and to add a hook to call when the xref output buffer is ready. > As another suggestion, would be nice to add more keybidings, for > example, to navigate between headers. Maybe bind more org-like bindings in outline-mode-cycle-map, e.g. ‘C-c C-n’ like ‘org-next-visible-heading’ and ‘C-c C-p’ like ‘org-previous-visible-heading’. > The name 'cycle', however, maybe not be a good choice in case Emacs > offers more keybidings for outline-minor-mode. Indeed, after adding more keybindings it's not only about cycling anymore.