From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Context menus and mouse-3 Date: Fri, 16 Jul 2021 01:31:25 +0300 Organization: LINKOV.NET Message-ID: <87a6mndxaa.fsf@mail.linkov.net> References: <20200914061111.3trmuzhdvv7nwdcc@Ergus> <87y2acv2tw.fsf@mail.linkov.net> <87sg0jt7bo.fsf@mail.linkov.net> <871r8123jg.fsf@mail.linkov.net> <87a6mojwu9.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6621"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: philipk@posteo.net, Richard Stallman , spacibba@aol.com, emacs-devel@gnu.org, arthur.miller@live.com, dgutov@yandex.ru, ghe@sdf.org, drew.adams@oracle.com To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 16 00:37:23 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m49ys-0001ar-LP for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Jul 2021 00:37:22 +0200 Original-Received: from localhost ([::1]:45112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m49yr-0005LG-LC for ged-emacs-devel@m.gmane-mx.org; Thu, 15 Jul 2021 18:37:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m49y7-0003HU-4H for emacs-devel@gnu.org; Thu, 15 Jul 2021 18:36:35 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:35745) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m49y4-0008BV-HH; Thu, 15 Jul 2021 18:36:34 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 957B3240005; Thu, 15 Jul 2021 22:36:22 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Wed, 14 Jul 2021 21:18:43 -0400") Received-SPF: pass client-ip=217.70.178.230; envelope-from=juri@linkov.net; helo=relay10.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271277 Archived-At: >> To pop up it immediately, I see no better way than currently >> is implemented for C-down-mouse-3 because then C-h k C-down-mouse-3 >> works smoothly as well as Undo selected from the menu keeps undoing >> on consequent calls, etc. > > Indeed. Maybe we can bring them together by (when > `mouse-3-down-context-menu` is t) using a remapping from `down-mouse-3` > to `context-menu`. It seems pretty intrusive, tho :-( I don't know what I did wrong but this does nothing: (global-set-key [down-mouse-3] [context-menu]) (global-set-key [context-menu] `(menu-item ,(purecopy "Context Menu") ignore :filter (lambda (_) (mouse-context-menu-map)))) whereas this works fine: (global-set-key [down-mouse-3] `(menu-item ,(purecopy "Context Menu") ignore :filter (lambda (_) (mouse-context-menu-map)))) > Maybe a better option is to make it so the `context-menu` event is kept > internal (give it a less attractive name), i.e. just an implementation > detail for the case where the menu pops up after a delay. A minor mode will also need to remove this binding (define-key key-translation-map [mouse-3] #'mouse--click-3-maybe-context-menu) when `mouse-3-down-context-menu` is t, and to unbind [mouse-3] from 'mouse-save-then-kill' because sometimes 'mouse-save-then-kill' still gets called, I haven't investigated why.