From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: New Context Menu Date: Mon, 23 Aug 2021 10:33:32 +0300 Organization: LINKOV.NET Message-ID: <87a6l8it83.fsf@mail.linkov.net> References: <20210818120834.i3orh535tb2enpos.ref@Ergus> <20210818120834.i3orh535tb2enpos@Ergus> <87r1epzznt.fsf@mail.linkov.net> <83zgtd2762.fsf@gnu.org> <87fsv4io41.fsf@mail.linkov.net> <838s0w1hiz.fsf@gnu.org> <871r6odq3s.fsf@mail.linkov.net> <83y28wyozn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15835"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: spacibba@aol.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 23 09:38:42 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mI4Xa-0003wE-A2 for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Aug 2021 09:38:42 +0200 Original-Received: from localhost ([::1]:46564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mI4XY-0003gK-Ek for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Aug 2021 03:38:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mI4X2-00030t-Nz for emacs-devel@gnu.org; Mon, 23 Aug 2021 03:38:08 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:55055) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mI4X0-0006ds-Nn; Mon, 23 Aug 2021 03:38:08 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 55ECEFF80B; Mon, 23 Aug 2021 07:38:01 +0000 (UTC) In-Reply-To: <83y28wyozn.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Aug 2021 21:01:32 +0300") Received-SPF: pass client-ip=217.70.183.199; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272864 Archived-At: >> >> What would be the best strategy for fixing these commands? This error >> >> is signaled for all commands that have (interactive "e"). Then such >> >> interactive spec should be removed from all commands used in the menu? >> > >> > I guess so. Why does it make sense for commands invoked from the >> > menus to have the "e" interactive spec? >> >> There are too many commands that have the "e" interactive spec. >> It would be much simpler not to signal an error for them, but produce >> a fake event where the clicked position is set to the position of point. > > Feel free to work on that (I guess that needs changes on the C > level?). Actually, I found out that no work is needed. When this restriction is removed from `call-interactively': if (next_event >= key_count) error ("%s must be bound to an event with parameters", (SYMBOLP (function) ? SSDATA (SYMBOL_NAME (function)) : "command")); then everything works fine thanks to the old decision to accept non-mouse events in event-start, event-end, event-click-count: (defun event-start (event) (if (consp event) (nth 1 event) (or (posn-at-point) (list (selected-window) (point) '(0 . 0) 0)))