Re: [PATCH] tab-line: New tab-line-tab-face-modified face

[Adam Porter <adam@alphapapa.net>]

Juri Linkov <juri@linkov.net> writes:

>>> But why font-lock-doc-face?  Have you tried to change tab background color?
>>> I guess this would be more visually pleasing.  Or maybe not.  This needs
>>> more experimentation.
>>
>> Because in the default theme, it results in text that's a dark red,
>> which is easily distinguished against the default tab background color,
>> while still being readable (IMHO).  It reminds me of other editors I've
>> used that use the red color to indicate a modified tab, so I think it
>> should be somewhat familiar to users.  And by using a "font-lock-" face,
>> it will be themed automatically by common third-party themes; while that
>> doesn't guarantee it will look good with any theme by default, it should
>> help.
>
> Ah, this explains everything - a dark red makes sense, but long ago
> I customized this face to green and forgot that by default it's dark
> red :)

LOL, that's so easy to do.  :)

> Thanks for the patch, now applied.

Thanks.