From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 691015fedb: Fix filelock.c for Haiku Date: Mon, 10 Jan 2022 08:08:16 +0800 Message-ID: <87a6g4sb9r.fsf@yahoo.com> References: <83pmp0al8c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32081"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 10 01:09:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n6iFx-00085T-4w for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Jan 2022 01:09:49 +0100 Original-Received: from localhost ([::1]:59856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n6iFu-0005rM-V7 for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Jan 2022 19:09:47 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6iEk-000573-4M for emacs-devel@gnu.org; Sun, 09 Jan 2022 19:08:34 -0500 Original-Received: from sonic312-25.consmr.mail.ne1.yahoo.com ([66.163.191.206]:41297) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n6iEh-0003gB-2H for emacs-devel@gnu.org; Sun, 09 Jan 2022 19:08:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1641773309; bh=Unu6s9LxkIN5QgSugxwBSuW8yRueqJJobRzQvDJmge4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=tZN71pjmFLXNBZ96m7Q65BlBRKMV32RAYYQnzFho2YKCN47crhiY/mf4XMCtOEixx4Cm099qBK3bpyXcr673qp+383sKg2ubTkkP4BwQ96YGoHiBswUMGPJ9/NYA1oELsUuGCwTlq6l22OJo7XqIvWdC8H6dYNixIKYSwZ1fIYRUm62NtKck5Wwxcu009fVMVavUj6s7tsNt6QmPaXRehRpFIC/+sJ0BOEabRdZYYlAz6e+58eC5gVXKI6bmfnnoF3xFwiF2htLCJZmaNLl47ZAz5XAo3VO+ITsCdqWtBwUy2AAM7lMypJ1xm+a6P0YtVryEOfTqUbMXkOS6ypCT9Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1641773309; bh=lFisBnl2D2V/M9/XJzMgdpjPTwyJKQlSRUQSg01qniD=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=oaIBxZ45QRtl4l7qtiagqj3vuL7YI6Y5hD/5FGEqkoP2aHJJILzSCQTi9uOCexl5qWbsq75RcyHy+pl3HHpYfToh3qO23nx2BQdHVC9qtdreVRjugQWRkQe2/m2lG0iV81s+R89Tkx/Ci6+45JvZx8VApDkGipS8CAoBPM5O1XRq0zG9/hi0A3ZDKjnVlXJrBVjzTiUDhT1pHp3dJ4XVPQca87F3d4roeymq9fEiM9+4JbrF4tl8jdgotIggd4vYcb7xJVhv8K/aAeFWwu2w1PRGDEadRRwM/9eEy1GSveBH23bKyHtdCyLyn9SjBzmvkE9DzXnI7LYvYFrMnRNuvQ== X-YMail-OSG: e44AZHEVM1lKEgRycK9J6DpMGRZMZSTR2gPrFYYGOQDz4S52v60KqNASl7CA6Yr e82iG7YIDhUyCW1xXUAZesUjMvbWKIx8nyxix9i2twr_s8A2oSMAbiUpJ88.up4ay27r7kHaUS_c A0u3efwCsTB43avPX1WjsawZ.Jb2sKPB2xYNdAjokyn4QVTYH3SZpwL23Eg8xLDcyk5iHXmfEGLa XIpSjUu6C2vDWOwCeKbvCkKI_ehCzdETZxKEt7sqZrWDzkk0zZfZF.LxtmLlB8TvYBOS7bvNGZzz mChP1QSjiXPBgAERcdPGvuUQNf4znanehkbQMug_YHD9fu.oV0txpWR3ZZsnIU0AtLRujgXKZxQn jphqg8plmdTbXf1sb002vxlnpKYvE0qhxQ5_wIesQom.jvBjtQi_Bsmr_Azff6MUD2_5Q7GdY0DH WcDrJBd0n9yBLIsBTC8jBFt5Tb9Rql4xaWEukp6ZtEIe_jybGpOvr7xQpKoPkNbd1g8huJnY_YFH EuBr3WzR4PkWUfrucijSVE0PEwS.P188isvdntOMufsgq0ImPxzlLj1roTbVzt_.T.plhCvpwYvT uMrn_IXGF2KoRh_VvBiDWoU2gkTveJVC0Oeqbdfu1O5hz8.vX8hshUzhTF254gGPNX5XGvyXCUD8 aUH2tId_PrKDPzI9t55CLdUXy0RRWBR5H1VWuqTBe01.1hIdVad3bID5AhXSlrIOU8fxWdJZV9OO Mvi4LUui5fZJt7QrnpGLsUoTumQRUOWBDAxVvw_Z76iAkM0T3dLBROSqSR4rKFXZe7AkHf.kuC4B q7HTty1wWiO6JnL9PT5lg_VNBbwOClnQBQ9.28UwSj X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Mon, 10 Jan 2022 00:08:29 +0000 Original-Received: by kubenode517.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 7a3df3a34285cde02335649843af0509; Mon, 10 Jan 2022 00:08:22 +0000 (UTC) In-Reply-To: <83pmp0al8c.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 09 Jan 2022 19:10:27 +0200") X-Mailer: WebService/1.1.19551 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.191.206; envelope-from=luangruo@yahoo.com; helo=sonic312-25.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284514 Archived-At: Eli Zaretskii writes: >> diff --git a/src/filelock.c b/src/filelock.c >> index a213c2b3ca..8453f17cd4 100644 >> --- a/src/filelock.c >> +++ b/src/filelock.c >> @@ -608,7 +608,7 @@ lock_if_free (lock_info_type *clasher, char *lfname) >> err = current_lock_owner (clasher, lfname); >> if (err != 0) >> { >> - if (err < 0) >> + if (err == -1 || err == -2) >> return -2 - err; /* We locked it, or someone else has it. */ >> break; /* current_lock_owner returned strange error. */ >> } >> @@ -616,7 +616,14 @@ lock_if_free (lock_info_type *clasher, char *lfname) >> /* We deleted a stale lock; try again to lock the file. */ >> } >> >> +#if !defined HAIKU \ >> + || defined BE_USE_POSITIVE_POSIX_ERRORS >> return err; >> +#else >> + /* On Haiku, POSIX error values are negative by default, but this >> + code's callers assume that any errno value is positive. */ >> + return -err; >> +#endif >> } > > Is it guaranteed that no errno value on Haiku cam ever be -1 or -2? Yes. > Do we perhaps want to add an assertion to that effect? I don't think that's necessary. > Btw, what kind of errno values does Haiku use? what do you see in the > errno.h header there? are all the values negative? They're aliased to BeOS error codes, which are all negative by quite a large value (INT_MIN + error_code).