From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: master 43237f3d27: ; * rcirc.el (rcirc-print): Prefer sleep-for over sit-for Date: Sat, 19 Feb 2022 21:04:23 +0000 Message-ID: <87a6emy3e0.fsf@posteo.net> References: <164529931177.1767.11895834409261548078@vcs2.savannah.gnu.org> <20220219193512.0F87BC00894@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34772"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 19 22:06:10 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLWvh-0008qR-Fz for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Feb 2022 22:06:09 +0100 Original-Received: from localhost ([::1]:60694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLWvg-0007EP-52 for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Feb 2022 16:06:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLWu6-0006Fc-Aj for emacs-devel@gnu.org; Sat, 19 Feb 2022 16:04:30 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:47607) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLWu4-0000ff-58 for emacs-devel@gnu.org; Sat, 19 Feb 2022 16:04:29 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5DCD6240103 for ; Sat, 19 Feb 2022 22:04:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1645304665; bh=yc9QgN7ryoJHiMb4LVj3CXiiysMFrr8HliJyI8/hR2c=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=N9zXf/wAmmq1pNtpmdyV/ULtZ88cwIZInNITpytrhCgf84QpV9tJRqDMfYo159mwI MiKcgx1H+s7IhDWaaiUsZhWFr/2369A7r6KlatTjWukG7ILiEf3Ep2v5i/mxUVvnS5 Uf0znlG4bFZBsRxQW7qreBVagtaNBO6dqfzrlHolfRcCEVqv6mHVaFa4/HOw/SpQz5 PqwKg+1nbPb+16RybI6LbfE/rZ6MUQMsbFutqponh2vcEdIcjrq14rcXlpOC5HmQYN 6h+bzZtGZg5fhhSvGKY1IUlpO9SCI4DMXmiTpC1w1TDZ/ahb5jODnE5lY05Jhlvdtz gbJB//LP8SYQA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4K1LfJ488Qz9rxB; Sat, 19 Feb 2022 22:04:24 +0100 (CET) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: (Stefan Monnier's message of "Sat, 19 Feb 2022 15:01:21 -0500") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286493 Archived-At: Stefan Monnier writes: > Philip Kaludercic [2022-02-19 14:35:11] wrote: >> branch: master >> commit 43237f3d27897e2a0c6de745770802d0ba40e3a5 >> Author: Philip Kaludercic >> Commit: Philip Kaludercic >> >> ; * rcirc.el (rcirc-print): Prefer sleep-for over sit-for >> >> Compare >> >> (benchmark-run 100000 (sit-for 0)) >> ;; => (2.600030102 12 1.523461324000003) >> >> with >> >> (benchmark-run 100000 (sleep-for 0)) >> ;; (0.015882939 0 0.0) > > I think that's because `sleep-for` doesn't redisplay whereas `sit-for` > (usually) does. > >> - (sit-for 0) ; displayed text before hook >> + (sleep-for 0) ; displayed text before hook > > What is this for? The comment suggests it might be because you want to > force a redisplay, but if `sleep-for` does the trick apparently that's not it. > > > Stefan > Eli Zaretskii writes: >> ; * rcirc.el (rcirc-print): Prefer sleep-for over sit-for >> >> Compare >> >> (benchmark-run 100000 (sit-for 0)) >> ;; => (2.600030102 12 1.523461324000003) >> >> with >> >> (benchmark-run 100000 (sleep-for 0)) >> ;; (0.015882939 0 0.0) >> >> diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el >> index 9d1600e..9bbba6d 100644 >> --- a/lisp/net/rcirc.el >> +++ b/lisp/net/rcirc.el >> @@ -2043,7 +2043,7 @@ rcirc-print >> rcirc-log-process-buffers)) >> (rcirc-log process sender response target text)) >> >> - (sit-for 0) ; displayed text before hook >> + (sleep-for 0) ; displayed text before hook > > Really? Why? > > sleep-for with the argument of zero is a fancy way of doing nothing, > so it definitely is going to be "faster". But then why call it at > all? > > The sit-for call was there to trigger redisplay. Now that's gone. > > I think you should revert that, or at least do something other than > call sleep-for with a zero argument. There was a misunderstanding on my end, I will revert the commit. My assumption was that sit-for was slower (hence slowing down playback) because it was also listening for input. I had been testing the change for a while and it seemed to not break anything, but I hadn't looked at it close enough. Sorry about that. -- Philip Kaludercic