From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Cc: "Mattias Engdegård" <mattiase@acm.org>
Subject: Re: master 6eeab90632: Don't accept whitespace or hex floats in rgbi: colour specs
Date: Sun, 06 Mar 2022 21:46:36 +0800 [thread overview]
Message-ID: <87a6e3p51f.fsf@yahoo.com> (raw)
In-Reply-To: <20220306130800.EE0F9C01681@vcs2.savannah.gnu.org> ("Mattias Engdegård"'s message of "Sun, 6 Mar 2022 08:08:00 -0500 (EST)")
Mattias Engdegård <mattiase@acm.org> writes:
> branch: master
> commit 6eeab90632506348a58d264eb3304625756c8659
> Author: Mattias Engdegård <mattiase@acm.org>
> Commit: Mattias Engdegård <mattiase@acm.org>
>
> Don't accept whitespace or hex floats in rgbi: colour specs
>
> `color-values-from-color-spec` (new in Emacs 28) erroneously accepted
> leading whitespace and hex floats in rgbi: components.
>
> Reported by Philip Kaludercic.
>
> * src/xfaces.c (parse_float_color_comp): Disallow leading whitespace
> and hex floats.
> * test/src/xfaces-tests.el
> (xfaces-internal-color-values-from-color-spec): Add test cases.
I don't see a corresponding bug report, so please forgive me if I missed
something here.
If the leading whitespace and hex floats don't cause problems, why not
keep the ability to understand them? It could come in handy.
Thanks.
next parent reply other threads:[~2022-03-06 13:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164657208058.1597.5057681041192670917@vcs2.savannah.gnu.org>
[not found] ` <20220306130800.EE0F9C01681@vcs2.savannah.gnu.org>
2022-03-06 13:46 ` Po Lu [this message]
2022-03-06 13:56 ` master 6eeab90632: Don't accept whitespace or hex floats in rgbi: colour specs Mattias Engdegård
2022-03-06 16:49 ` [External] : " Drew Adams
2022-03-07 0:34 ` Po Lu
2022-03-07 9:26 ` Philip Kaludercic
2022-03-07 10:16 ` Po Lu
2022-03-07 15:16 ` Philip Kaludercic
2022-03-07 9:31 ` Mattias Engdegård
2022-03-07 10:14 ` Po Lu
2022-03-07 13:36 ` Mattias Engdegård
2022-03-07 13:52 ` Po Lu
2022-03-07 16:06 ` [External] : " Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6e3p51f.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).