From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 242a4b49cb: Minor cleanups to X drag-and-drop code Date: Fri, 20 May 2022 20:05:51 +0800 Message-ID: <87a6bcwgrk.fsf@yahoo.com> References: <838rqwbfcp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35333"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 20 14:07:59 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ns1QE-00094L-N3 for ged-emacs-devel@m.gmane-mx.org; Fri, 20 May 2022 14:07:58 +0200 Original-Received: from localhost ([::1]:37846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ns1QD-0004Ca-DV for ged-emacs-devel@m.gmane-mx.org; Fri, 20 May 2022 08:07:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns1OP-0003Mk-Gn for emacs-devel@gnu.org; Fri, 20 May 2022 08:06:05 -0400 Original-Received: from sonic301-31.consmr.mail.ne1.yahoo.com ([66.163.184.200]:45375) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ns1OO-0006hy-0S for emacs-devel@gnu.org; Fri, 20 May 2022 08:06:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653048362; bh=aaJ8iaoAYkREj7PTAnQBgYSK71JzqEqRkNK3nc25Xn4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=HOwWljZNM/MAyHmzgJcp20emmYjoAs/qb29VhbboO7dyKehqFPx6cZswzmZSVQ+xxvxY6Q6rcUE7M2PAyNOazcVXKT8tbzwE9wyq6B1f7zKbpr9EZ/BpfB5h0KmfbWt+dypRGzhL36El6/uNBKeeX8lFR3IbZQwevVFq5R+c+L8kwwXWUAANOY6wzv9tAq+2LdH1xlIZouaG5IssTolPP4TezPO38I1MTw5I8EiqiOWJ18zbcuAGkaQJ6tUOZBSpOryJAAvrJwJDirOSwQ6pw2ETjvh7dnADk5ugGgCPwiyyoBq5b5rTsxiS4uZW4o+yjReT8kkp2qkvcTXl94LmZw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653048362; bh=CcXYo8xXpETOyCV+vwFbAdCMghCRh9M+NpyXFvwHb6F=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=qrhUCH0XmeEN6bzbw8C9vzB8Q2b/ysGXTcIaDTr/oAxaAm6GyRtGi1+ukKzhKSIGlukUo+TipNylQaAZpO2C+C9g6WgJuG/JdpqEs3jJVi+1f83/FDAy9jYod2Ph1xX/aom33JDJtdYVhO5PXspHdihIxeukqInz1wmW1Ll9/HyQ+pVTQ9m2dkWYKZDjJFd1IlSlafjVrZTF1Y7ehv9LfpLHN2VY3dcNvUn8xxRUTWEqtO1vcWSBJhFTXMJYAhrbNO+t33qz6IMRUchfSWgsfZxXTK7kka0BH6PcwLI3C6lrE+3/+c6COGvkACfWgldFzFg6QnNVCKr8ubNOX3R+Vg== X-YMail-OSG: 91nTKSMVM1kbkEzDhwJXgXuhrpAXAhdgU_7cxAVdppPalQuTAgXF08ydMdXbU_u LFQ6Md6SjyyMYq.p7h96VgLPggXKUxKGbLwFZRH5zX5OSR2.HzCpId44y_RRhsi32GJg5le5JgW3 lccpyemNOnjnU_gKQhSKwwjCSDbXILKsFzbSyV2t7PwI4c5vDs0tJ9n9R8lERdGW4LIRqRP9J5Hi pXKAVLAqEQxdOTSvAU2kMfdh8Ly2HmsDM_D9ZoonVnwhGRJTBoLQjDOmkVg1ZmvcpG9Gzc5avaa3 m7B.tX1.xcR5sd_v.pfWGwvSb64B4k4q7wUAsD73QYd1xoHG1alLgrY_vVa0Jdv43xTdxlZKX51A jwwbjvpRDsgOgcCYCGClRZJDmSCSN3y.u74U7u5WJOJN5dmpHEdVlrUC6FEpNS1tAcWBGvhGNknc bZ5odihkaHojrgeTTjUCMWQv0iPO76nnYQqb2dI3W6qd6Ggb91mr0IrKFn.xmYXqJ3qsoa4_ieGN yY7WC5T71kf7CA6hpjdpkOqnW52GEzsYkNrB_8xkhQSYiBUrhqJDkp6b14sAFzKWOfFcwEYi_9md Gq6_kctD1oe3hHnG90ZBvYrjVTdzdmDxBq5LziWNgWLJZozJCwEZJbdLFgYRTrCV3lB0DFUh0Ews ykRNcPIrxdChqfLDC92h4d6xDXv53Bc9YiWYsfvruPaaMbOI4SlKXlVRomPivflSzJAGVuf_OSDJ jUExtlMN0MqKOg6zS.gvUUGII_qjVWWUW293w5delpm3fEAboZWLWULJ2uCau3xXWHSyOwDNidgN u5QfWjN61pHyshCU0ufHPmdCDsoVciLXMy_sJwMMZq X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Fri, 20 May 2022 12:06:02 +0000 Original-Received: by hermes--canary-production-sg3-7959d4d9bd-lwwxg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 208c14c4e8a3e27487be79b6d20c59f1; Fri, 20 May 2022 12:05:57 +0000 (UTC) In-Reply-To: <838rqwbfcp.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 May 2022 14:41:58 +0300") X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.184.200; envelope-from=luangruo@yahoo.com; helo=sonic301-31.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289999 Archived-At: Eli Zaretskii writes: >> + /* The event mask for the window before Emacs selected for events on >> + it. */ >> long previous_event_mask; > There's something wrong with this comment: I cannot parse that > sentence. It's the bitmask of input events that Emacs asked (selected) for previous to it being changed in `x_dnd_compute_toplevels'. I see the problem with the comment now, and will correct it. Thanks.