From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.devel Subject: Re: [External] : [emacs bookmark.el] Sorting by last set Date: Sun, 05 Jun 2022 18:16:28 +0200 Message-ID: <87a6ar84rn.fsf@elite.giraud> References: <875ylhvu4k.fsf@red-bean.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14378"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) Cc: Lars Ingebrigtsen , Stefan Monnier , Drew Adams , emacs-devel To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 05 18:21:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nxt0Y-0003Z0-T5 for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Jun 2022 18:21:42 +0200 Original-Received: from localhost ([::1]:44188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nxt0X-0004m3-M1 for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Jun 2022 12:21:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxsvn-0000nO-Vq for emacs-devel@gnu.org; Sun, 05 Jun 2022 12:16:50 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:28265) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxsvm-0001Gb-0x for emacs-devel@gnu.org; Sun, 05 Jun 2022 12:16:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=rKXzomw+Rlh/195v nJ8guRvdcr1GIToHzf999mmSSJ4=; h=in-reply-to:date:references:subject: cc:to:from; d=ledu-giraud.fr; b=kUcJ+UJYw1Dh8w2w/k/o4lzUDIsnmeSiulUFlF 5Xx/sKd0YYxjnRnaaorqcJGv+74flWdJaf4HElyi2AUy/A8V0+BIEMlkxdGbObNlQkU9CY +Hahc5DlBUTah1oOOLLBdmbinf3Ia/AVOBkjZDTUXto0Giyv1OsllENQ5IOHkt4IMRrZ1b ONWj5617BBBUvjZAoOrxNrqqq6me3o8iledb8BPvhD8y1/ecwo7jSuAsnSDQyf/k1AyCAL 20RmBsU4N1Yr5Pt7VP8Kw3lS7v3QvW9CEefwd5nNP3t2nX1Ml6va+0yl5MMhzt2YAPJlrz X84Qf/DAr1zEu5M8vOB3Bf1A== Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id fbd8222a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 5 Jun 2022 18:16:39 +0200 (CEST) In-Reply-To: <875ylhvu4k.fsf@red-bean.com> (Karl Fogel's message of "Sat, 04 Jun 2022 01:07:55 -0500") Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290731 Archived-At: Karl Fogel writes: > A few thoughts I just had while looking over the recent improvement to > bookmark.el sorting (commit f461eb8fa -- not the later followup commit > fccde52158, which isn't relevant for these thoughts): Hi Karl and thanks for your time on this, [...] > The simple solution would be to just change the symbol to > `last-set-date'. I think that would be my choice. It would > reduce the potential for confusion and misunderstanding. Yes, I forgot about annotations so I think `last-set-date' would be better. I could prepare this simple patch. [...] > * Now that we're using a symbol for *one* possible value of > `bookmark-sort-flag', should we use symbols for *all* possible > values? (And leave the treatments of `t' and nil as legacy > compatibility behaviors, documented as such but deprecated in > favor of using the corresponding new symbols instead when writing > new configurations.) Why not... but we have to settle for good symbol names. I propose 'last-created (as nil) and 'alphabetical (as t). [...] > However, I think it would be good to deprecate `bookmark-sort-flag' > in favor of 'bookmark-sort-behavior' or something, and do whatever > the usual compatibility dance is for such situations. It's useful > for the suffix "-flag" to actually mean something, and I'd rather > not have bookmark.el contribute to the dilution of that linguistic > tradition. That also makes sense but I prefer `bookmark-sort'. Also, I don't know how to deprecate a custom in emacs. Best regards, -- Manuel Giraud