unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ivan Sokolov <ivan-p-sokolov@ya.ru>
To: emacs-devel@gnu.org
Subject: [PATCH] Option for sorting package-selected-packages
Date: Sun, 26 Mar 2023 02:39:21 +0300	[thread overview]
Message-ID: <87a600mmdy.fsf@ya.ru> (raw)

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

Nowadays many people keep their configuration under a VCS. I think this
new option might help them get tidier diffs and avoid merge conflicts.

It might make sense to enable this option by default.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: [PATCH] New option for sorting package-selected-packages --]
[-- Type: text/x-patch, Size: 1696 bytes --]

From eb996ddc331e34a1c97331768420b9c6dfd30c15 Mon Sep 17 00:00:00 2001
From: Ivan Sokolov <ivan-p-sokolov@ya.ru>
Date: Fri, 24 Mar 2023 23:27:13 +0300
Subject: [PATCH] New option for sorting package-selected-packages

* lisp/emacs-lisp/package.el (package-sort-selected-packages): New defcustom.
---
 lisp/emacs-lisp/package.el | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 0258ed52bee..1e11be4ab3b 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -404,6 +404,13 @@ a sane initial value."
   :version "25.1"
   :type '(repeat symbol))
 
+(defcustom package-sort-selected-packages nil
+  "If non-nil interactive functions will sort `package-selected-packages'.
+You can use this variable to get a nicer diffs if you keep your
+`custom-file' under version control system."
+  :version "30.1"
+  :type 'boolean)
+
 (defcustom package-native-compile nil
   "Non-nil means to natively compile packages as part of their installation.
 This controls ahead-of-time compilation of packages when they are
@@ -1974,7 +1981,10 @@ Used to populate `package-selected-packages'."
 (defun package--save-selected-packages (&optional value)
   "Set and save `package-selected-packages' to VALUE."
   (when value
-    (setq package-selected-packages value))
+    (setq package-selected-packages
+          (if package-sort-selected-packages
+              (sort value #'string<)
+            value)))
   (if after-init-time
       (customize-save-variable 'package-selected-packages package-selected-packages)
     (add-hook 'after-init-hook #'package--save-selected-packages)))
-- 
2.39.2


             reply	other threads:[~2023-03-25 23:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-25 23:39 Ivan Sokolov [this message]
2023-03-26 10:24 ` [PATCH] Option for sorting package-selected-packages Philip Kaludercic
2023-03-26 12:00   ` Ivan Sokolov
2023-04-02 21:10 ` [PATCH v2] Sort package-selected-packages on save Ivan Sokolov
2023-10-01 12:27   ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a600mmdy.fsf@ya.ru \
    --to=ivan-p-sokolov@ya.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).